Skip to content

Comments

feat(web): add option to reset storage config#1986

Merged
joseivanlopez merged 4 commits intoagama-project:storage-config-uifrom
joseivanlopez:storage-reset-config
Feb 17, 2025
Merged

feat(web): add option to reset storage config#1986
joseivanlopez merged 4 commits intoagama-project:storage-config-uifrom
joseivanlopez:storage-reset-config

Conversation

@joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Feb 11, 2025

Add Reset to defaults option into the More options menu.

Screenshot on an s390x system with several disks:

s390

Screenshot on a non-s390x system with several disks:

other

@joseivanlopez joseivanlopez force-pushed the storage-reset-config branch 2 times, most recently from 06826d5 to f2ae3c6 Compare February 11, 2025 12:54
@joseivanlopez joseivanlopez changed the title feat(web): add reset to defaults option feat(web): add option to reset storage config Feb 11, 2025
@joseivanlopez joseivanlopez force-pushed the storage-reset-config branch 4 times, most recently from 2f77123 to 4e0ac76 Compare February 14, 2025 15:33
@ancorgs
Copy link
Contributor

ancorgs commented Feb 14, 2025

I would take this as an opportunity to clean-up/reorganize "more options". Let's say:

  • Change boot options
  • Reset to default configuration
  • [Separator]
  • Configure iSCSI
  • [s390 stuff (with their current titles)]

@dgdavid
Copy link
Contributor

dgdavid commented Feb 14, 2025

I would take this as an opportunity to clean-up/reorganize "more options". Let's say:

  • Change boot options
  • Reset to default configuration
  • [Separator]
  • Configure iSCSI
  • [s390 stuff (with their current titles)]

Excuse my ignorance, but what about LVM and RAID options? Part of "Use additional disk"?

@ancorgs
Copy link
Contributor

ancorgs commented Feb 14, 2025

Excuse my ignorance, but what about LVM and RAID options? Part of "Use additional disk"?

No. They will be here... but we have not implemented any UI for them yet. :-(

@dgdavid
Copy link
Contributor

dgdavid commented Feb 14, 2025

No. They will be here... but we have not implemented any UI for them yet. :-(

Ah, right. So, the idea is to remove them by now and decide later their place, isn't it?

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13369643824

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 24.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-lib/src/storage/client.rs 0 2 0.0%
rust/agama-server/src/storage/web.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 13334599182: -0.02%
Covered Lines: 1747
Relevant Lines: 7001

💛 - Coveralls

@ancorgs
Copy link
Contributor

ancorgs commented Feb 17, 2025

Just a note. At #1972 we agreed on the following wording for the buttons/links displayed on the empty state screens (sure is not the same context, so we don't have to reproduce them here):

  • Reset to the default configuration
  • Connect to iSCSI targets
  • Activate zFCP disks
  • Manage DASD devices

Not sure what is better here. Maybe those are too long and even confusing for a drop-down menu. Or maybe they could be used as descriptions. Something like:

  • Change boot options - Select the disk to configure partitions for booting
  • Reset to defaults - Start from scratch with the default configuration
  • [Separator]
  • Configure iSCSI - Discover and connect to iSCSI targets
  • Configure zFCP - Activate zFCP disks
  • Configure DASD - Activate and format DASD devices

@dgdavid
Copy link
Contributor

dgdavid commented Feb 17, 2025

Just a note. At #1972 we agreed on the following wording for the buttons/links displayed on the empty state screens (sure is not the same context, so we don't have to reproduce them here):

* Reset to the default configuration

* Connect to iSCSI targets

* Activate zFCP disks

* Manage DASD devices

That was a good improvement, indeed.

Not sure what is better here. Maybe those are too long and even confusing for a drop-down menu. Or maybe they could be used as descriptions. Something like:

* Change boot options - Select the disk to configure partitions for booting

* Reset to defaults - Start from scratch with the default configuration

* [Separator]

* Configure iSCSI - Discover and connect to iSCSI targets

* Configure zFCP - Activate zFCP disks

* Configure DASD - Activate and format DASD devices

I'd go for something like this. Items with descriptions.

@agama-project agama-project deleted a comment from joseivanlopez Feb 17, 2025
@ancorgs ancorgs marked this pull request as ready for review February 17, 2025 11:52
@ancorgs ancorgs force-pushed the storage-reset-config branch from df390c7 to 9e63bc3 Compare February 17, 2025 11:54
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 3588012 into agama-project:storage-config-ui Feb 17, 2025
5 checks passed
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants