web: Better storage summary#2003
Conversation
| {drives.length === 1 && <SingleDiskSummary drive={drives[0]} />} | ||
| {drives.length > 1 && <MultipleDisksSummary drives={drives} />} | ||
| <Content> | ||
| {configModel && <ModelSummary model={configModel} />} |
There was a problem hiding this comment.
NP: do we need to pass the model as prop? Just saying because after some discussions with @dgdavid, we decided that the components should recover all the info they need from hooks. But maybe in this case we want a component which is able to render different models?
There was a problem hiding this comment.
Exactly. Somehow we realize that it's better having components able to query the information they need when possible instead of depending on the props of some parent. Not written in stone, of course, but thanks to the React Query cache most of times it works fine.
But maybe in this case we want a component which is able to render different models?
Good point.
joseivanlopez
left a comment
There was a problem hiding this comment.
What happens if there is a config with errors?
Nothing special. The summary sentence simply explains what the configuration is about, it does not tell anything about whether is a good or bad configuration. That's the mission for the part of the interface displaying issues. That's not new in my PR, that's how the summary works. So the only change here is to better handle the situation in which we cannot explain the configuration. |
Exactly. There is room for improvements, though. But it has to wait until reserving time for improving the overview page itself, where these summaries are being rendered right now. |
Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083
Problem
When the configuration uses some feature not supported by the UI (like LVM or
legacyAutoyastStorage), the storage section of the summary shows this message: "No device selected yet". Even if the configuration leaded to a valid storage setup.Solution
Now the situation is properly handled and the message makes more sense.