chore: improve web navigation menu and sync with master#2021
Merged
dgdavid merged 148 commits intostorage-config-uifrom Feb 20, 2025
Merged
chore: improve web navigation menu and sync with master#2021dgdavid merged 148 commits intostorage-config-uifrom
master#2021dgdavid merged 148 commits intostorage-config-uifrom
Conversation
This reverts commit 74b1d46. We decided to not go with dracut approach and instead use systemd service
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>
## Problem As there is no linuxrc in Agama we want to explore the possibility of translating linuxrc network-related boot arguments into the dracut equivalent (which is the supported and recommended method for the new installation media). - https://jira.suse.com/browse/AGM-38 - https://trello.com/c/iCICenNT ## Solution A basic translation of the **ifcfg** boot argument has being implemented as a prof of concept but as the nm-initrd-generator parses de cmdline as a cmdline hook it is too early for doing some kind of checks about the devices present in the system and trying to match against the device name and the mac address therefore any kind of pattern except the **'*'** wildcard. **Supported examples** - ifcfg=*=dhcp ip=dhcp - ifcfg=eth0=dhcp ip=eth0:dhcp - ifcfg=eth0.10=192.168.0.100/24,192.168.0.1 vlan=eth0.10:eth0 ip=192.168.0.100::192.168.0.1:24::eth0.10 - ifcfg="eth0=192.168.0.33/24 10.0.0.100/24,192.168.0.1,192.168.0.1 10.0.0.1,suse.de" ip=192.168.0.33::192.168.0.1:24::eth0 nameserver=192.168.0.1 nameserver=10.0.0.1 ip=10.0.0.100:::24::eth0 The parser is also added as a cmdline hook, we explored the possibility to call it as a **initqueue/settle** hook, in that case we could try to call the **nm_generate_connections** function directly passing it the **getcmdline** result. At that point we can check the devices present in **/sys/class/net/** doing some filtering based in the name or mac address but for example the try function requires to run the configuration in order to check if the interface was configured or not for continuing trying... for that kind of support we might need to add it to NetworkManager and the nm-initrd-generator. ## Testing - *Tested manually*
Add the QEMU guest agent.
## Problem - #1985 - The current UI is not much intuitive 😟  ## Solution - Better button labels (now even translated!) - "Try again" is now the default - Display a title to have a context - Describe the consequences of skipping package installation - @dgdavid proposed even more enhancements (see [his comment](#1985 (comment))), but that would require non trivial enhancements ## Notes - This is not a perfect solution, the current Query API is quite limited - I'll create a new card for enhancing the API to allow some more features (and remove the current workarounds) ## Testing - Tested manually ## Screenshots    --------- Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com> Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
It was declared, but not passed to the internal ModalHeader component.
## Problem There is plan to adopt new authentication model where root password does not need to be set and use other ways to authenticate. trello: https://trello.com/c/qRvd2Q4K/4182-5-agama-unattended-support-for-the-new-authentication-model ## Solution As the first step ensure that unattended installation allows and works with new authentication model. This includes following changes: - first user will be in wheel group - root password is explicitelly locked if not specified - if root ssh key is used, ensure that sshd is enabled and firewall has port open - for TW/slowroll use new first user policy by installing proper package ## Testing - *Tested manually* ## AI - [x] check SLES situation
imobachgs
approved these changes
Feb 19, 2025
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Given it is a sync, I guess it is OK.
imobachgs
requested changes
Feb 19, 2025
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Please, do not merge, tests are failing.
Contributor
|
It looks like the merge is wrong. We removed |
Contributor
Author
Sorry @imobachgs I was aware of the autologin removal, but for some unknown reason I messed it up while resolving the merge conflict 😢 Fortunately we have tests 😉 Please find the offending lines removed at e3b060e |
Update AutoYaST compatibility documentation.
Introduces the `alsoActiveOn` attribute to the RouteHandle, allowing navigation menu items to be highlighted for alternative paths. This ensures menu items stay active when multiple routes lead to the same component, useful for cases where different URLs should trigger the same active state in the navigation.
dgdavid
changed the title
storage-config-ui with mastermaster
dgdavid
changed the title
mastermaster
## Problem - The Live ISO does not boot  ## Solution - Fix the syntax error ## Testing - Tested manually, the ISO boots fine
Merged
imobachgs
added a commit
that referenced
this pull request
Feb 26, 2025
Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another sync with
masterbranch which also includes a small improvement in routes for being able to mark as active a route in multiple paths. Useful for having "Overview" highlighted in root path too. See commit ff582d4