Skip to content

Comments

fix(ruby): enable the agama-scripts service if installed#2083

Merged
imobachgs merged 3 commits intomasterfrom
enable-agama-scripts
Feb 26, 2025
Merged

fix(ruby): enable the agama-scripts service if installed#2083
imobachgs merged 3 commits intomasterfrom
enable-agama-scripts

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Feb 26, 2025

Ensure the agama-scripts service is enabled so that "init" scripts run on the first boot. This one is the second part of #2080.

It enables this service in the same way AutoYaST enables autoyast-initscripts.

Tests

@imobachgs imobachgs marked this pull request as ready for review February 26, 2025 01:13
@imobachgs imobachgs force-pushed the enable-agama-scripts branch from d9311aa to 2135dc7 Compare February 26, 2025 01:14
@imobachgs imobachgs force-pushed the enable-agama-scripts branch from 2135dc7 to 543c161 Compare February 26, 2025 01:15
@imobachgs imobachgs force-pushed the enable-agama-scripts branch from 1b469e2 to 7ddb3ed Compare February 26, 2025 06:40
private

# Run the post scripts
def run_post_scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I think all these things about scripts are misplaced in a storage finisher.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are quite some things that do not belong here. We will find better places as we continue moving stuff to Rust.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 8915680 into master Feb 26, 2025
10 checks passed
@imobachgs imobachgs deleted the enable-agama-scripts branch February 26, 2025 06:59
This was referenced Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants