Conversation
Pull Request Test Coverage Report for Build 13386011811Details
💛 - Coveralls |
There was a problem hiding this comment.
Taking a look to the screenshots in the description
I'd not use icon as part of the titleBut using it does not hurt and it is ok. Moreover, you have used the one used in the installation button when there are issues, which is great in terms of consistence.- I'd try to keep the buttons order. I.e, not adding the abort installation in the middle of the other two, which changes the order of buttons.
- I'd use a "tertirary" or "plain" variant for the "Abort installation" action, if possible. Also, I'd add the "isDanger" prop.
imobachgs
left a comment
There was a problem hiding this comment.
Just some minor things. Otherwise, it looks much better now.
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Co-authored-by: David Díaz <1691872+dgdavid@users.noreply.github.com>
This is a bit tricky. The problem is that the only safe option is "Try again". Both "Continue anyway" and "Abort installation" can result in a broken or not bootable system. Although skipping a package feels a bit less dangerous in the end it does not matter if your system does not boot because of a single missing package or two dozens. I do not want to create a false impression that skipping a package is a safe option. It's not. It's equally dangerous as aborting the installation. Moreover this change would require non trivial enhancement of the |
dgdavid
left a comment
There was a problem hiding this comment.
Let's merge it, thank you
Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083
Problem
Solution
Notes
Testing
Screenshots