web: Synchronous probing when registering or choosing product#2072
Merged
ancorgs merged 2 commits intoagama-project:masterfrom Feb 25, 2025
Merged
web: Synchronous probing when registering or choosing product#2072ancorgs merged 2 commits intoagama-project:masterfrom
ancorgs merged 2 commits intoagama-project:masterfrom
Conversation
Merged
imobachgs
added a commit
that referenced
this pull request
Feb 26, 2025
Prepare for releasing Agama 12: * #1858 * #1887 * #1890 * #1892 * #1893 * #1894 * #1896 * #1898 * #1899 * #1900 * #1901 * #1906 * #1908 * #1909 * #1910 * #1911 * #1912 * #1914 * #1915 * #1917 * #1919 * #1920 * #1921 * #1922 * #1923 * #1924 * #1926 * #1927 * #1928 * #1929 * #1930 * #1931 * #1932 * #1933 * #1934 * #1935 * #1936 * #1937 * #1938 * #1939 * #1942 * #1943 * #1945 * #1948 * #1949 * #1952 * #1953 * #1954 * #1955 * #1957 * #1958 * #1959 * #1961 * #1963 * #1964 * #1967 * #1969 * #1970 * #1971 * #1972 * #1973 * #1974 * #1975 * #1976 * #1977 * #1979 * #1980 * #1981 * #1982 * #1984 * #1986 * #1987 * #1988 * #1990 * #1991 * #1992 * #1993 * #1995 * #1996 * #1997 * #1999 * #2000 * #2001 * #2002 * #2003 * #2004 * #2005 * #2006 * #2007 * #2008 * #2009 * #2010 * #2011 * #2012 * #2013 * #2014 * #2015 * #2016 * #2017 * #2019 * #2021 * #2022 * #2025 * #2027 * #2029 * #2030 * #2031 * #2033 * #2034 * #2035 * #2036 * #2037 * #2038 * #2039 * #2040 * #2045 * #2046 * #2050 * #2053 * #2054 * #2055 * #2056 * #2058 * #2060 * #2061 * #2062 * #2063 * #2064 * #2066 * #2067 * #2068 * #2069 * #2070 * #2071 * #2072 * #2073 * #2075 * #2076 * #2080 * #2082 * #2083
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 26, 2025
https://build.opensuse.org/request/show/1248590 by user IGonzalezSosa + dimstar_suse - Version 12 - Add fonts for CJK characters and monospaced text (gh#agama-project/agama#2076, bsc#1237457). - Display the file system labels in most selectors for disks and partitions (gh#agama-project/agama#2070). - Use the backend's language as fallback, ignoring the browser's one It reduces the chances to produce unwanted side-effects when connecting to the web user interface (gh#agama-project/agama#2071). - Do not block when connecting during system installation. - Make some small fixes/improvements to the overview, localization and software pages markup. - Synchronous system probing when choosing or registering the product (gh#agama-project/agama#2072). - Display network edition errors instead of navigating back (gh#agama-project/agama#2064). - Ignore non-critical i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is a race condition that leads to the interface reporting that there are no available devices after changing the product or registering it.
Moreover, even if that race condition is not hit, the interface is displaying the previous storage configuration. That's wrong because changing the product or registering actually resets the storage configuration at the backend (the registration case is debatable, but that's what happens now).
Solution
Do a synchronous probing and invalidate all the storage queries when probing has finished. With that, the UI contains an up-to-date representation of the backend reality.
Testing
Tested manually