Skip to content

Comments

Remove the local media in the installed system (bsc#1236813)#1975

Merged
lslezak merged 3 commits intomasterfrom
disable_local_media
Feb 6, 2025
Merged

Remove the local media in the installed system (bsc#1236813)#1975
lslezak merged 3 commits intomasterfrom
disable_local_media

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Feb 5, 2025 •
edited
Loading

Problem

  • When installing SLE16 from the offline medium the initial installation repository is present in the installed system
  • However it cannot be reached with URL dir:///run/initramfs/live/install, that directory does not exist in installed system
  • See https://bugzilla.suse.com/show_bug.cgi?id=1236813

Solution

  • Simply remove the repository,

Testing

  • Added a new unit test
  • Tested manually, when using the offline medium there is no repository defined in the installed system

Notes

  • Some unrelated Rspec test fails, but that happened even before these changes 😟

@lslezak
Disable the local media in the installed system (bsc#1236813)
b249051 
esp. disable the offline repository with URL
dir:///run/initramfs/live/install
@lslezak
Fix unit test
87eebe1
@lslezak
Update unit test
f7ae4a3
ancorgs
ancorgs reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mvidner
mvidner approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 1e2df32 into master Feb 6, 2025
8 of 10 checks passed
@lslezak lslezak deleted the disable_local_media branch February 6, 2025 14:31
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
Merged
imobachgs added a commit that referenced this pull request Feb 26, 2025
@imobachgs
Update to release 12 (#2084)
52d9ff6 
Prepare for releasing Agama 12:

* #1858
* #1887
* #1890
* #1892
* #1893
* #1894
* #1896
* #1898
* #1899
* #1900
* #1901
* #1906
* #1908
* #1909
* #1910
* #1911
* #1912
* #1914
* #1915
* #1917
* #1919
* #1920
* #1921
* #1922
* #1923
* #1924
* #1926
* #1927
* #1928
* #1929
* #1930
* #1931
* #1932
* #1933
* #1934
* #1935
* #1936
* #1937
* #1938
* #1939
* #1942
* #1943
* #1945
* #1948
* #1949
* #1952
* #1953
* #1954
* #1955
* #1957
* #1958
* #1959
* #1961
* #1963
* #1964
* #1967
* #1969
* #1970
* #1971
* #1972
* #1973
* #1974
* #1975
* #1976
* #1977
* #1979
* #1980
* #1981
* #1982
* #1984
* #1986
* #1987
* #1988
* #1990
* #1991
* #1992
* #1993
* #1995
* #1996
* #1997
* #1999
* #2000
* #2001
* #2002
* #2003
* #2004
* #2005
* #2006
* #2007
* #2008
* #2009
* #2010
* #2011
* #2012
* #2013
* #2014
* #2015
* #2016
* #2017
* #2019
* #2021
* #2022
* #2025
* #2027
* #2029
* #2030
* #2031
* #2033
* #2034
* #2035
* #2036
* #2037
* #2038
* #2039
* #2040
* #2045
* #2046
* #2050
* #2053
* #2054
* #2055
* #2056
* #2058
* #2060
* #2061
* #2062
* #2063
* #2064
* #2066
* #2067
* #2068
* #2069
* #2070
* #2071
* #2072
* #2073
* #2075
* #2076
* #2080
* #2082
* #2083
@lslezak lslezak changed the title Disable the local media in the installed system (bsc#1236813) Remove the local media in the installed system (bsc#1236813) Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ancorgs ancorgs ancorgs left review comments

@mvidner mvidner mvidner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lslezak @mvidner @ancorgs