Skip to content

[rust] improvements in agama logs store#1762

Merged
mchf merged 11 commits intomasterfrom
extended_collected_logs
Nov 29, 2024
Merged

[rust] improvements in agama logs store#1762
mchf merged 11 commits intomasterfrom
extended_collected_logs

Conversation

@mchf
Copy link
Contributor

@mchf mchf commented Nov 14, 2024

Problem

  • some information were missed in the result

Solution

  • added journal output for (new) agama-web-server
  • collected package versions (either .packages.root or "rpm -qa")
  • minor improvements - do not include empty files (when command produces no output) into the resulting archive; do not mask errors reported by the backend (either authentication required)
  • added service running busctl monitor on agama's bus in the background and collectin errors in dbus.log, the log file is then put into the resulting archive

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 12081805839

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 71.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-cli/src/logs.rs 0 1 0.0%
rust/agama-lib/src/base_http_client.rs 0 6 0.0%
rust/agama-lib/src/logs.rs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/base_http_client.rs 1 53.85%
Totals Coverage Status
Change from base Build 12072405397: -0.02%
Covered Lines: 16936
Relevant Lines: 23843

💛 - Coveralls

@mchf mchf requested a review from imobachgs November 22, 2024 14:55
@mchf mchf force-pushed the extended_collected_logs branch from 0a2c147 to aad639b Compare November 24, 2024 17:13
@mchf mchf marked this pull request as ready for review November 24, 2024 17:14
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looking much better now. Thanks!

@mchf mchf requested a review from imobachgs November 28, 2024 08:44
@mchf mchf force-pushed the extended_collected_logs branch from b0eae68 to 27bb3ef Compare November 28, 2024 09:04

file_stdout.write_all(&output.stdout)?;
file_stderr.write_all(&output.stderr)?;
if output.stdout.len() > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: There is a little bit of duplication, but I can live with that.

@mchf mchf force-pushed the extended_collected_logs branch from ada1e06 to cc2b7e3 Compare November 29, 2024 08:58
@mchf mchf merged commit f85440d into master Nov 29, 2024
@mchf mchf deleted the extended_collected_logs branch November 29, 2024 09:38
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants