Skip to content

fix(web): drop DeviceSelection#1914

Merged
joseivanlopez merged 6 commits intoagama-project:storage-config-uifrom
joseivanlopez:drop-deviceselection
Jan 17, 2025
Merged

fix(web): drop DeviceSelection#1914
joseivanlopez merged 6 commits intoagama-project:storage-config-uifrom
joseivanlopez:drop-deviceselection

Conversation

@joseivanlopez
Copy link
Copy Markdown
Contributor

Problem

The DeviceSelection component is not used anymore and it has a lot of code.

Solution

Remove DeviceSelection and all the code associated to it.

@joseivanlopez joseivanlopez changed the base branch from master to storage-config-ui January 17, 2025 09:47
@joseivanlopez joseivanlopez marked this pull request as ready for review January 17, 2025 09:47
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12826606039

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.006%) to 72.51%

Files with Coverage Reduction New Missed Lines %
rust/agama-server/src/web/ws.rs 1 0.0%
rust/agama-server/src/web.rs 2 0.0%
Totals Coverage Status
Change from base Build 12826538658: -0.006%
Covered Lines: 18939
Relevant Lines: 26119

💛 - Coveralls

@joseivanlopez joseivanlopez merged commit 3a3e0a2 into agama-project:storage-config-ui Jan 17, 2025
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants