fix using agama.install_url with equal in param#1803
Merged
jreidinger merged 5 commits intomasterfrom Dec 3, 2024
Merged
Conversation
dgdavid
reviewed
Dec 3, 2024
Comment on lines
+40
to
+48
| it "converts 'true' and 'false' values into booleans" do | ||
| args = described_class.read_from(File.join(workdir, "/proc/cmdline")) | ||
| expect(args.data["web"]).to eql({ "ssl" => true }) | ||
| end | ||
|
|
||
| it "converts keys that contain another dots after 'agama.' to hash value and using first value as key" do | ||
| args = described_class.read_from(File.join(workdir, "/proc/cmdline")) | ||
| expect(args.data["web"]).to eq({ "ssl" => true }) | ||
| end |
Contributor
There was a problem hiding this comment.
These examples has identical expectations. Is it ok?
Contributor
Author
There was a problem hiding this comment.
yes, as both test uses original fixture, so I would like to here emphasize that it do "hashisize" of key and also normalize of value. My plan was to use separate examples with documented ones from https://agama-project.github.io/docs/user/boot_options sadly noone of those options are documented, so I just keep it for testing regressions.
| it "properly parse values that contain '='" do | ||
| args = described_class.read_from(File.join(workdir, "/proc/cmdline")) | ||
| expect(args.data["install_url"]).to eq("cd:/?devices=/dev/sr1") | ||
| end |
Contributor
There was a problem hiding this comment.
Is there a missing example for testing the "auto" value?
Contributor
Author
There was a problem hiding this comment.
no, for auto it is plain option and it is in top level one at https://github.com/agama-project/agama/pull/1803/files#diff-68c3c88c1cfcfdc461f9d92425b028aa4ed3ca2a8c6239f2325b01fc4b0c8567R32
here it is intentionally using real cd schema that user complain on slack
Pull Request Test Coverage Report for Build 12147701143Details
💛 - Coveralls |
dgdavid
approved these changes
Dec 3, 2024
Merged
imobachgs
added a commit
that referenced
this pull request
Jan 13, 2025
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We get report that using agama with
agama.install_url=cd:/?devices=/dev/sr1to read repository from second dvd does not work.Solution
Fix parsing cmdline arguments which do too much splitting for each argument.
Testing