Fix storage config

[jreidinger]

Problem

There is collision between #1848 and #1840 where bootloader adds another interface with Get/SetConfig on Storage service. This result that generic access no longer works and needs access via specific interface.

reported on slack https://suse.slack.com/archives/C02TLF25571/p1734924853266999

Solution

Change code to avoid ambitious code.

Testing

• Tested manually

[coveralls]

Pull Request Test Coverage Report for Build 12471458359

Details

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• 3 unchanged lines in 2 files lost coverage.
• Overall coverage remained the same at 70.87%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
service/lib/agama/dbus/clients/storage.rb	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
service/lib/agama/dbus/clients/storage.rb	1	87.88%
service/service/lib/agama/dbus/clients/storage.rb	2	87.88%

Totals
Change from base Build 12433973856:	0.0%
Covered Lines:	17132
Relevant Lines:	24174

---

💛 - Coveralls

[dgdavid]

Although DBus stuff are not my thing, rationale and code looks good to me. If you tested it and it works, I guess you can go ahead.

Nevertheless, I have left a comment to be discussed in a near future, if needed.

[dgdavid]

Interesting. I wonder if it worth to always use the corresponding iface to avoid more errors like the one this commit fixes and get rid of specific comment.

Something to be discussed, not a blocker for this PR.

[jreidinger]

yeah, it is zbus way to always use combination of service, interface and object. On other hand ruby-dbus use different way and allow access throught interface, but for simplicity if method in unique, it is added directly to object. My original fix change dbus_object to always return interface, but then mixins start failing as it uses some methods that is not in interface. (during test e.g. this mixins failing https://github.com/agama-project/agama/blob/master/service/lib/agama/dbus/clients/with_service_status.rb#L43 ).
Maybe it will be better to have beside dbus_object also dbus_interface method on which we should call all needed storage methods ( that is idea that I get after thinking a bit more about it after I have working solution and not enough time to test different one ).

[dgdavid]

Merging it as requested in the internal team-yast Slack channel.