refactor(web): simplify page to enforce root password#1821
Merged
Conversation
Since this screen is shown in an intrusive way when installation settings do not ensure root access, it has been simplified to be less intimidating. The SSH key input is no longer offered; instead, users are prompted to set a password. The message now includes information about changing the password or choosing another authentication method later from the 'Users' section. refactor(web): simplify page to force a root password
lslezak
approved these changes
Dec 9, 2024
Contributor
lslezak
left a comment
lslezak
left a comment
There was a problem hiding this comment.
Yes, looks much better now! Thanks! 👏
dgdavid
added a commit
that referenced
this pull request
Dec 10, 2024
Just a missing changes file entry for #1821
Merged
imobachgs
added a commit
that referenced
this pull request
Jan 13, 2025
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
dgdavid
added a commit
that referenced
this pull request
Feb 15, 2025
With the authentication model now defined, stop enforcing the root password as a mandatory step that was hijacking the user workflow. This reverts the changes introduced in #1787 and #1821. Related to https://trello.com/c/7ewFvR0X (internal link)
imobachgs
added a commit
that referenced
this pull request
Feb 18, 2025
Apart from **eliminating the step introduced in #1821 to force users to enter a password for root**, this PR significantly revamps the interface of the Authentication page (formerly the Users page) to reduce its complexity and make interactions more intuitive. Summarizing a lot, the key changes include improving the first user form and moving the root user authentication methods to a new form. This allows users to easily set or clear authentication methods without having to navigate complex actions. I.e., tables and most dynamic actions have been eliminated, making the page much easier to interact with and enabling users to quickly find the options they need. | Authentication page | Root user form | |-|-| | |  | However, there are still areas for improvement: * Enhance validations and the underlying code that supports them. * Decouple the input with suggestions from the FirstUserForm (move it to the core namespace). * Use a simpler widget/input for adding public SSH keys. While the current one works, it is somewhat complex and not well-suited for these form’s use cases. * Enable the ability to add more than one public SSH key. ## Note for reviewers > [!WARNING] > After commit c7c424c this PR needs changes done at #2005 (not merged at the time of writing). Please jump into the branch and use the interface as part of the review process. If interested in the details, check commits. --- Related to https://trello.com/c/7ewFvR0X (internal link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During a review meeting on December 9th, it was argue that the new screen for enforcing at least one root authentication method could be intimidating for some users, mainly due to the inclusion of the SSH public key input field.
Solution
In the same meeting, it was suggested to hide the SSH public key input and display it only upon user request, taking the opportunity for also providing a brief explanation of what an SSH public key is.
While this was a good idea, after testing a couple of approaches it became apparent that there were several corner cases, all of them leading to add too much user interaction to an already intrusive screen that should be kept as minimalist as possible.
Thus, the input has been completely removed instead. Now, the page ask for the root password and provides information to let users aware about the possibility to change the root authentication method at any time before installation from the Users section.
Testing
Screenshots
Related to https://trello.com/c/GQytAUEU (internal link)