Skip to content

Comments

feat(web): Migration to PatternFly v6, round 3#1954

Merged
dgdavid merged 12 commits intostorage-config-uifrom
pfv6-round-3
Jan 29, 2025
Merged

feat(web): Migration to PatternFly v6, round 3#1954
dgdavid merged 12 commits intostorage-config-uifrom
pfv6-round-3

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jan 28, 2025

A continuation of #1900 and #1921. To know more about introduced changes, please see commit by commit, but it basically still polishing visual aspects after the migration to PF6

The idea of this PR is to minimize the risk of big merge conflicts by introducing adjustments done until now in the feature branch ASAP. But still not being the last migration round.

Bring back some styles for making it looks a bit better and allow
the drawer recieves the focus when open.
There is a lot of room for improvements, but this commits start changing
a bit the breakpoints values and the sidebar behavior becuase most
probably Agama will target a lot of 1024x768 screen resolutions, for
which is dedired to start with the sidebar open and fixed.
Mainly to make form labels looks better with SUSE font.
To make it looks better with adjustements made for PF/Alert.
For using a PF/Alert instead of a PF/EmptyState when the proposal is not
possible.
For stop using core/EmptyState and fine-tunning its look&feel.
By using a link instead of a button for the action since it is the right
component from a semantic point of view: it performs a navigation for
taking the user to another place.
Instead of making it part of the result section, move it to the top
since it makes more sense and creates a place where explain better to
users what might help to have a valid proposal.
Used previously for adding an skeleton of each part of the interface
affected by a use interaction. It is no longer needed with the new
interface approach.
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 2bc80bc into storage-config-ui Jan 29, 2025
2 checks passed
@dgdavid dgdavid deleted the pfv6-round-3 branch January 29, 2025 07:59
dgdavid added a commit that referenced this pull request Feb 3, 2025
dgdavid added a commit to joseivanlopez/agama that referenced this pull request Feb 5, 2025
Lost while deleting all previous CSS during the migration to PF6. I.e.,
related to

  - agama-project#1900
  - agama-project#1921
  - agama-project#1954
  - agama-project#1961
dgdavid added a commit to joseivanlopez/agama that referenced this pull request Feb 6, 2025
Lost while deleting all previous CSS during the migration to PF6. I.e.,
related to

  - agama-project#1900
  - agama-project#1921
  - agama-project#1954
  - agama-project#1961
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants