Skip to content

Use better ISO Volume ID labels (bsc#1236401)#1955

Merged
lslezak merged 6 commits intomasterfrom
iso_label
Feb 7, 2025
Merged

Use better ISO Volume ID labels (bsc#1236401)#1955
lslezak merged 6 commits intomasterfrom
iso_label

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Jan 28, 2025

Problem

Solution

  • Change the logic to use the Kiwi profile name as part of the Volume ID
  • Make the profile names more descriptive (include the version where it makes sense)

Notes

  • The Volume ID label is limited to max. 32 characters
  • The openSUSE profile can install both Leap and Tumbleweed distributions so do not include any version name there

Implementation details

  • The volid Kiwi attribute for ISO images can be only a static text, we cannot do something like ${profile}-${arch}
  • It is not used for the oem images, removed
  • We already changed the Volume ID in the fix_bootconfig script so just make it better

Testing

  • Tested manually
> isoinfo -d -i agama-installer.x86_64-11.0.0-Leap-16.0-Build.iso | grep "Volume id"
Setting input-charset to 'UTF-8' from locale.
Volume id: Install-Leap-16.0-x86_64
> isoinfo -d -i agama-installer.x86_64-11.0.0-SUSE-SLE-16-Build.iso | grep "Volume id"
Setting input-charset to 'UTF-8' from locale.
Volume id: Install-SUSE-SLE-16-x86_64

Additional fixes

  • Allow starting the UEFI firmware configuration from the boot menu
  • Display graphical menu also in SLE (fixed theme support)

Boot menu labels

  • While touching the fix_bootconfig script I also improved the Grub2 boot menu
  • Use the profile name and the architecture there as well, it is much better than generic agama-installer which does not tell much to the users.

Screenshots

Leap 16.0 ISO
agama-leap-boot-menu

Generic openSUSE ISO
agama-opensuse-boot-menu

Just for comparison the old openSUSE boot menu
agama-opensuse-boot-menu-old

SLE16 ISO (graphical mode)
agama-sle-boot-menu-gui

SLE16 ISO (text mode)
agama-sle-boot-menu

SLE16 ISO, when booting in EFI system additional "UEFI Firmware Settings" item is displayed
agama-sle-boot-menu-gui-efi

- Improve also the boot menu labels
@lslezak lslezak marked this pull request as draft January 28, 2025 16:11
@lslezak lslezak marked this pull request as ready for review February 7, 2025 08:14
@lslezak lslezak merged commit fd4bb8c into master Feb 7, 2025
4 checks passed
@lslezak lslezak deleted the iso_label branch February 7, 2025 08:19
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
imobachgs added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants