Skip to content

Use AgamaProposal for the initial storage proposal#1699

Merged
ancorgs merged 16 commits intoagama-project:storage-config-uifrom
ancorgs:probe_agama_proposal
Oct 28, 2024
Merged

Use AgamaProposal for the initial storage proposal#1699
ancorgs merged 16 commits intoagama-project:storage-config-uifrom
ancorgs:probe_agama_proposal

Conversation

@ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 25, 2024 •
edited
Loading

We decided to stop relying on the YaST proposal and always use the new so-called AgamaProposal both for the auto-installation and for the interactive one.

This makes that change effective by generating an initial storage configuration that fulfills the product settings and executing AgamaProposal for it during the storage probing phase.

Bonus

This includes a merge of master into the feature branch. To keep things in sync and, even more important, to get some fixes from there.

ancorgs and others added 6 commits October 24, 2024 16:21
@ancorgs
storage: do not register issues when skipping entries at the config
70253e0
@ancorgs
Changelog
6e491c0
@ancorgs @joseivanlopez
Fix text in unit test
811ecb9 
Co-authored-by: José Iván López <joseivanlopez@gmail.com>
@ancorgs
Storage: Do not register issues when skipping entries at the config (a…
d0e1ca2 
…gama-project#1696)

## Problem

At the storage configuration, it's possible to specify a section
describing a device (drive, partition, volume group, logical volume,
etc.) with a `search` entry to indicate such a description corresponds
to one or several previously existing device(s) that should be found in
the system.

That `search` entry can contain `ifNotFound: "skip"` to indicate the
description should be ignored if the corresponding devices are not
found.

If that happens, a warning is added to the list of found issues with a
message like "_No device found for an optional
drive/partition/whatever_".

That warning looks overkill. Especially having into account the default
value for `ifNotFound` is "error", which means profiles using "skip"
really mean it.

## Solution

Reduce the noise by not longer generating the issue for missing optional
devices.
@joseivanlopez
fix(schema): place scripts section correctly
135dde6
@joseivanlopez
fix(schema): place scripts section correctly (agama-project#1698)
9579a95 
## Problem

The *scripts* section is misplaced in the profile schema (inside
*storage* section)

## Solution

Place *scripts* section at first level.
@ancorgs ancorgs force-pushed the probe_agama_proposal branch from d139a2b to 14f4d79 Compare October 25, 2024 14:49
@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11557338726

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • 102 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 71.521%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-lib/src/network/client.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-server/src/storage/web.rs 33 0.0%
rust/agama-lib/src/storage/client.rs 69 0.0%
Totals Coverage Status
Change from base Build 11517918801: -0.03%
Covered Lines: 16977
Relevant Lines: 23737
💛 - Coveralls

@ancorgs ancorgs force-pushed the probe_agama_proposal branch from 14f4d79 to 8694e5f Compare October 25, 2024 15:10
@imobachgs
fix(rust): use POST to apply the network configuration
e6843dc
@imobachgs
docs(rust): update changes file
bf08155
@imobachgs
Fix network method (agama-project#1702)
b1e266b 
## Problem

See agama-project#1701. The CLI uses a PUT instead of a POST when applying the
network configuration.

## Solution

Use the correct HTTP verb when applying the network configuration.

## Testing

- Tested manually
@imobachgs
docs(products): fix changes file
c7fa683
@imobachgs
docs(products): fix changes file (agama-project#1703)
d1062ee 
The products definition package could not be submitted due to a problem
in a date format.
@ancorgs ancorgs force-pushed the probe_agama_proposal branch from 8694e5f to 6ee1a8b Compare October 28, 2024 11:38
@ancorgs ancorgs changed the title WIP: Use AgamaProposal for the initial storage proposal Use AgamaProposal for the initial storage proposal Oct 28, 2024
@ancorgs ancorgs marked this pull request as ready for review October 28, 2024 11:48
@ancorgs ancorgs force-pushed the probe_agama_proposal branch from 6ee1a8b to 12049b5 Compare October 28, 2024 11:50
joseivanlopez
joseivanlopez requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a changelog entry.

ancorgs and others added 4 commits October 28, 2024 16:03
@ancorgs
Update ruby-augeas
e703167
@ancorgs
Update ruby-augeas to fix problem at CI (agama-project#1705)
56b8a8d 
## Problem

The checks at GitHub were failing for new pull requests because it was
not possible to install ruby-augeas 0.5.0 at the containers.

Apparently that was triggered by a recent update of the version of the
package at openSUSE Tumbleweed (it moved to 0.6.0).

## Solution

This updates `Gemfile.lock` to use the same version that is now
available on Tumbleweed. Apparently that fixes CI for the new pull
requests.
@ancorgs
Merge branch 'master' into probe_agama_proposal
336cb2b
@ancorgs
Changelog
18c8139
@ancorgs ancorgs force-pushed the probe_agama_proposal branch from 2d59206 to 18c8139 Compare October 28, 2024 15:32
@ancorgs ancorgs merged commit 2aceec0 into agama-project:storage-config-ui Oct 28, 2024
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
Merged
imobachgs added a commit that referenced this pull request Jan 13, 2025
@imobachgs
Update to release 11 (#1887)
3ab318a 
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joseivanlopez joseivanlopez joseivanlopez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ancorgs @coveralls @joseivanlopez @imobachgs