Skip to content

fix: display error messages during installation#1909

Merged
imobachgs merged 6 commits intomasterfrom
fix-error-reporting
Jan 16, 2025
Merged

fix: display error messages during installation#1909
imobachgs merged 6 commits intomasterfrom
fix-error-reporting

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jan 16, 2025 •
edited
Loading

Problem

If something goes wrong during packages installation, Agama web UI does not show any message. We
found out that there are some problems:

  • When the connection goes down, TanStack Query will not perform any request (until the network is
    up).
  • The UI might loose the QuestionsChanged event if it is reconnecting the WebSocket at that point.

Solution

To overcome those problems, we have introduced the following changes:

  • Set TanStack Query network mode to "always" when running on localhost.
  • Invalidate questions query when the WebSocket is reconnected to make sure we do not miss any
    message.

Note

We could play with the refetchOnReconnect setting at global level. But let's be conservative at
this point.

Additional changes

agama-web-server:

  • Exit the WebSocket handler when the client is disconnected
  • Log the events

web UI:

  • refactor(web): expose onerror and onclose at WSClient level

Testing

  • Tested manually

Screenshots

Error message from libzypp

@imobachgs imobachgs marked this pull request as ready for review January 16, 2025 13:36
@imobachgs imobachgs merged commit 33324bd into master Jan 16, 2025
7 checks passed
@imobachgs imobachgs deleted the fix-error-reporting branch January 16, 2025 13:57
@dgdavid dgdavid mentioned this pull request Jan 31, 2025
Closed
@imobachgs imobachgs mentioned this pull request Jan 31, 2025
Merged
imobachgs added a commit that referenced this pull request Feb 6, 2025
@imobachgs
fix(web): set mutations network mode to "always" (#1963)
08d0a52 
## Problem

The web UI does not perform any mutation when the network gets
disconnected.

## Solution

Set the network mode to `always` for mutations, as they have a separate
set of default options from queries. This change is analogous to what we
did in #1909 for queries.

## Testing

- Tested manually
@lslezak lslezak mentioned this pull request Feb 11, 2025
Closed
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
Merged
imobachgs added a commit that referenced this pull request Feb 26, 2025
@imobachgs
Update to release 12 (#2084)
52d9ff6 
Prepare for releasing Agama 12:

* #1858
* #1887
* #1890
* #1892
* #1893
* #1894
* #1896
* #1898
* #1899
* #1900
* #1901
* #1906
* #1908
* #1909
* #1910
* #1911
* #1912
* #1914
* #1915
* #1917
* #1919
* #1920
* #1921
* #1922
* #1923
* #1924
* #1926
* #1927
* #1928
* #1929
* #1930
* #1931
* #1932
* #1933
* #1934
* #1935
* #1936
* #1937
* #1938
* #1939
* #1942
* #1943
* #1945
* #1948
* #1949
* #1952
* #1953
* #1954
* #1955
* #1957
* #1958
* #1959
* #1961
* #1963
* #1964
* #1967
* #1969
* #1970
* #1971
* #1972
* #1973
* #1974
* #1975
* #1976
* #1977
* #1979
* #1980
* #1981
* #1982
* #1984
* #1986
* #1987
* #1988
* #1990
* #1991
* #1992
* #1993
* #1995
* #1996
* #1997
* #1999
* #2000
* #2001
* #2002
* #2003
* #2004
* #2005
* #2006
* #2007
* #2008
* #2009
* #2010
* #2011
* #2012
* #2013
* #2014
* #2015
* #2016
* #2017
* #2019
* #2021
* #2022
* #2025
* #2027
* #2029
* #2030
* #2031
* #2033
* #2034
* #2035
* #2036
* #2037
* #2038
* #2039
* #2040
* #2045
* #2046
* #2050
* #2053
* #2054
* #2055
* #2056
* #2058
* #2060
* #2061
* #2062
* #2063
* #2064
* #2066
* #2067
* #2068
* #2069
* #2070
* #2071
* #2072
* #2073
* #2075
* #2076
* #2080
* #2082
* #2083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imobachgs @dgdavid