Skip to content

Make the "lang" URL query optional#1984

Merged
lslezak merged 1 commit intomasterfrom
nonEFI-fix
Feb 10, 2025
Merged

Make the "lang" URL query optional#1984
lslezak merged 1 commit intomasterfrom
nonEFI-fix

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented Feb 10, 2025

Problem

  • Agama fails starting locally on non-UEFI systems

agama-missing-lang

Details

Solution

  • Make the lang URL query parameter optional

Testing

  • Tested manually in bot UEFI and non-UEFI (standard BIOS) systems

- Do not fail when it is missing
- This fixes crash on non-UEFI systems
@lslezak lslezak merged commit dbd4927 into master Feb 10, 2025
6 checks passed
@lslezak lslezak deleted the nonEFI-fix branch February 10, 2025 14:13
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13242191167

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 70.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/web/http.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 13223989973: -0.003%
Covered Lines: 17442
Relevant Lines: 24569

💛 - Coveralls

@bittin
Copy link
Copy Markdown
Contributor

bittin commented Feb 11, 2025

This is fixed now, thanks for taking care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants