Skip to content

feat(web): re-introduce the storage encryption settings#2031

Merged
joseivanlopez merged 18 commits intomasterfrom
storage-config-ui-encryption
Feb 21, 2025
Merged

feat(web): re-introduce the storage encryption settings#2031
joseivanlopez merged 18 commits intomasterfrom
storage-config-ui-encryption

Conversation

@dgdavid
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid commented Feb 20, 2025 •
edited by joseivanlopez
Loading

First iteraration to bring the encryption section back.

The implementation at backend side is very simplistic and it does not properly work with several scenarios, for example:

  • If some partitions are encrypted and others don't.
  • If different encryptions are used (e.g., a password for root and other for home).

In those cases, the model considers that all the new partitions are encrypted, and the encryption config is taken from either the root partition or any other encrypted partition.

Note that these scenarios can only happen if a custom config is loaded. They cannot be accomplished by using the UI.

dgdavid
dgdavid commented Feb 20, 2025
View reviewed changes
Base automatically changed from storage-config-ui to master February 20, 2025 13:44
@dgdavid dgdavid changed the title feat(web) re-introduce the storage encryption settings. feat(web) re-introduce the storage encryption settings Feb 20, 2025
dgdavid
dgdavid commented Feb 20, 2025
View reviewed changes
web/src/components/storage/EncryptionSettingsPage.tsx
import { ActionGroup, Alert, Checkbox, Content, Form, Stack, Switch } from "@patternfly/react-core";
import { Page, PasswordAndConfirmationInput } from "~/components/core";
import { EncryptionMethods } from "~/types/storage";
import sizingStyles from "@patternfly/react-styles/css/utilities/Sizing/sizing";
Copy link
Copy Markdown
Contributor Author

@dgdavid dgdavid Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to drop this and its usage, but need a bit more of time for testing how to limit the width used by the Checkbox description without affecting to the rest of the form and allowing Form#isWidthLimited to do its work properly.

Will invest some time on Monday, if priorities permits.

@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch 5 times, most recently from 17b590a to 19ea4df Compare February 21, 2025 06:19
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13459450863

Details

  • 23 of 25 (92.0%) changed or added relevant lines in 8 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 72.525%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/storage/config_conversions/from_model_conversions.rb 0 1 0.0%
service/lib/agama/storage/config_conversions/to_model_conversions.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
service/lib/agama/storage/config_conversions/from_model_conversions.rb 2 0.0%
service/lib/agama/storage/config_conversions/to_model_conversions.rb 2 0.0%
service/lib/agama/storage/proposal.rb 2 97.78%
Totals Coverage Status
Change from base Build 13443082010: 0.0%
Covered Lines: 19758
Relevant Lines: 27243
💛 - Coveralls

@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch 4 times, most recently from e5670df to 298e066 Compare February 21, 2025 11:25
@ancorgs

This comment was marked as resolved.

Sign in to view
@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch from 298e066 to 3d6a47d Compare February 21, 2025 12:35
@joseivanlopez joseivanlopez changed the title feat(web) re-introduce the storage encryption settings feat(web): re-introduce the storage encryption settings Feb 21, 2025
@ancorgs
Copy link
Copy Markdown
Contributor

ancorgs commented Feb 21, 2025

I just wanted to mention that the length of the form feels a big inconsistent depending on whether TPM is possible or not.

I will fixed with a hack just for today.

@dgdavid

This comment was marked as resolved.

Sign in to view
@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch from 3d6a47d to 322710e Compare February 21, 2025 13:56
dgdavid and others added 10 commits February 21, 2025 14:05
@dgdavid @joseivanlopez
fix(web): rename component for encryption section
b50cd47 
It is not a "field" anymore.
@dgdavid @joseivanlopez
feat(web): add path for storage encryption
3d1a151
@dgdavid @joseivanlopez
feat(web): revamp encryption section interface
a9b83dd 
This commit simplifies the encryption section by displaying only useful,
read-only information to users and providing a consistent "Edit" action
to navigate to the encryption settings page, where users can adjust the
settings.
@dgdavid @joseivanlopez
fix(web): rename EncryptionSettingsDialog
00575b1 
It will no longer be a modal dialog, but a page instead.
@dgdavid @joseivanlopez
feat(web): add route for encryption settings
1e6f38f
@dgdavid @joseivanlopez
feat(web): re-introduce the encryption settings
13f8f0f 
Now implemented as a form in its dedicated route/page.

Note that:

 * It's unclear how to handle the isEnabled status—whether to hide the
   rest of the widgets or disable them. Disabling them allows users to
   see what they'll find, but we should apply the same approach across all
   forms, which isn't currently the case for the RootUserForm.

 * Tests are still pending, as we're not using real hooks, making
   testing difficult. Recreating fake tests would not be worthwhile.
@joseivanlopez
feat(storage): add general encryption to model
6691d44
@joseivanlopez
web: update config-model types
18e44c7
@joseivanlopez
web: add hook to get the encryption methods
0578f09
@joseivanlopez
web: add hooks to manage the global encryption
dd7a77b
@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch from 2ab59aa to 07f61b1 Compare February 21, 2025 14:06
ancorgs
ancorgs reviewed Feb 21, 2025
View reviewed changes
dgdavid
dgdavid commented Feb 21, 2025
View reviewed changes
dgdavid
dgdavid commented Feb 21, 2025
View reviewed changes
@joseivanlopez joseivanlopez force-pushed the storage-config-ui-encryption branch from 6ab8dbc to 544c138 Compare February 21, 2025 15:01
ancorgs
ancorgs approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is, of course, far from perfection. But it exactly what we need (and can afford) now.

@joseivanlopez joseivanlopez merged commit acd9e34 into master Feb 21, 2025
14 checks passed
@joseivanlopez joseivanlopez deleted the storage-config-ui-encryption branch February 21, 2025 15:14
@imobachgs imobachgs mentioned this pull request Feb 26, 2025
Merged
imobachgs added a commit that referenced this pull request Feb 26, 2025
@imobachgs
Update to release 12 (#2084)
52d9ff6 
Prepare for releasing Agama 12:

* #1858
* #1887
* #1890
* #1892
* #1893
* #1894
* #1896
* #1898
* #1899
* #1900
* #1901
* #1906
* #1908
* #1909
* #1910
* #1911
* #1912
* #1914
* #1915
* #1917
* #1919
* #1920
* #1921
* #1922
* #1923
* #1924
* #1926
* #1927
* #1928
* #1929
* #1930
* #1931
* #1932
* #1933
* #1934
* #1935
* #1936
* #1937
* #1938
* #1939
* #1942
* #1943
* #1945
* #1948
* #1949
* #1952
* #1953
* #1954
* #1955
* #1957
* #1958
* #1959
* #1961
* #1963
* #1964
* #1967
* #1969
* #1970
* #1971
* #1972
* #1973
* #1974
* #1975
* #1976
* #1977
* #1979
* #1980
* #1981
* #1982
* #1984
* #1986
* #1987
* #1988
* #1990
* #1991
* #1992
* #1993
* #1995
* #1996
* #1997
* #1999
* #2000
* #2001
* #2002
* #2003
* #2004
* #2005
* #2006
* #2007
* #2008
* #2009
* #2010
* #2011
* #2012
* #2013
* #2014
* #2015
* #2016
* #2017
* #2019
* #2021
* #2022
* #2025
* #2027
* #2029
* #2030
* #2031
* #2033
* #2034
* #2035
* #2036
* #2037
* #2038
* #2039
* #2040
* #2045
* #2046
* #2050
* #2053
* #2054
* #2055
* #2056
* #2058
* #2060
* #2061
* #2062
* #2063
* #2064
* #2066
* #2067
* #2068
* #2069
* #2070
* #2071
* #2072
* #2073
* #2075
* #2076
* #2080
* #2082
* #2083
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 26, 2025
@bmwiedemann
Update agama to version 0 / rev 15 via SR 1248595
9721891 
https://build.opensuse.org/request/show/1248595
by user IGonzalezSosa + dimstar_suse
- Version 12

- Add the missing shebang line to the agama-scripts.sh shell script
  (gh#agama-project/agama#2077).
- Save logs after running post installation scripts
  (gh#agama-project/agama#2078).

- Keep the encoding when storing the locale (gh#agama-project/agama#2062).

- Extend storage model schema to support global encryption
  (gh#agama-project/agama#2031).

- Introduce the storage model to support the new storage user
  interface (gh#agama-project/agama#2033)

- Expose root and first user passwords (gh#agama-project/agama#2005).
- Remove support for auto-login.

- Added reboot command to the CLI (gh#agama-project/agama#1970)

- Set console and X11 keymaps when changing the installer keymap
  (bsc#1236174).
- Use the "dashed" form of the keymap identifier when calling
  systemd-firstboo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ancorgs ancorgs ancorgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgdavid @coveralls @ancorgs @joseivanlopez