Release 4.2.4 Planning #4321
Labels
meta
Issues and PRs related to the general management of the project.
Comments
jasnell
added
the
meta
|
It's probably worth listing things that have not made it in to v4.x-staging since v4.2.1, if anyone has the time to look over these and comment on things they think should have made it but haven't please do so! This discussion is important to continue having so early in our figuring-out-how-to-LTS phase.
|
|
+1 thanks @rvagg! I think most of these should already have the lts-watch
|
|
I've been going through that list pretty regularly and was planning another pass tomorrow morning. If I recall a good number of them were less than two weeks old and needed a little more time to settle in. |
|
|
|
@alexlamsl ... not sure I follow. This would be a normal LTS maintenance release, not a sensitive security update. Some of the commits in @rvagg's originated from nodejs/node-private, yes, but those are already disclosed as they already landed in nodejs/node master. There's no need to discuss it in nodejs/node-private. |
|
@jasnell as I'm not part of the inner circle, I've never come across that repo before hence got curious. Thanks a lot for the clarification! |
|
@alexlamsl ..yeah, the nodejs/node-private repo is a mirror of nodejs/node that is used strictly to work on and review sensitive security changes that have not yet been openly disclosed. |
|
Here is the list of commits that are currently staged in Update: going through the commits now, putting a check mark on the items that definitely should pull over into v4.x ... note: this list has not yet been reconciled with @rvagg's list above
|
|
Slightly updated version of @rvagg's list... with checkboxes. going through them now and will update the list periodically, removing the ones that definitely should not land in v4.x-staging...
|
|
EDIT: nevermind, it is already listed as such |
|
Ok, I've paired the list in #4321 (comment) down to only the commits that should land in v4.x-staging. There's still a very large number of commits and most have landed only recently. Given that the we already have a long list of commits pending I propose that we move ahead with v4.2.4 using the commits already in v4.x-staging and push this second set of commits to another release in early January. @rvagg @nodejs/lts @nodejs/ctc ... thoughts? |
|
Release Proposal here => #4336 |
|
@djphoenix I think it was decided to wait on the fix as it had only been in master a couple days when this release started. We will be cutting another release early in the new year which, barring any weird regressions, will include that commit |
|
Should the AsyncWrap commits not be included? See the conclusion in nodejs/Release#59 (comment) |
|
Those will be bundled into 4.2.5. There will be a fairly quick turnaround
|
|
One bit I noticed re: AsyncWrap is that we're not properly calling the |
|
@chrisdickinson It is a known issue see: #3241 A known issue overview can be found at: nodejs/diagnostics#29 |
|
@AndreasMadsen Ah, this is different — It's not that connecting to a server from inside the process is missing context, it's that all http incomingmessages lack context because they are consumed at the C++ layer, and the resulting |
|
Since the release is done, can this be closed? |
|
closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just an fyi.. @nodejs/lts @nodejs/ctc ... I will be starting to pull together the v4.2.4 release proposal tomorrow. We currently have 150+ commits staged and waiting in v4.x-staging. I don't want to let that continue to grow. The current plan is to get the proposal ready by tomorrow with a release on Tuesday of next week.
The text was updated successfully, but these errors were encountered: