doc: remove old description for compare method #4227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-52
added
buffer
|
It shouldn't be removed, but instead moved to underneath |
|
You're right! Thank you. I've corrected it. 😉 |
| @@ -267,6 +264,8 @@ region in the same buffer | |||
|
|
|||
| * `otherBuffer` {Buffer} | |||
|
|
|||
| Returns a boolean indicating whether this and otherBuffer have the same bytes. | |||
There was a problem hiding this comment.
The backticks are missing around this and otherBuffer.
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature
|
Sorry, it should be ok now. |
|
LGTM |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 11, 2015
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature PR-URL: #4227 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 1a21a53 |
|
It looks like this is your first contribution to core @janriemer! Thanks for the PR and welcome on board! |
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature PR-URL: #4227 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature PR-URL: #4227 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature PR-URL: #4227 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
the description of buffer.equals(otherBuffer) was at the wrong place; move it underneath the method signature PR-URL: nodejs#4227 Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Above the buffer.compare(otherBuffer) method, there seems to
be a description from an older version of this method.
I have removed it.