doc: add method links in events.markdown #3187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
doc
| Many objects in Node.js emit events: a `net.Server` emits an event each time | ||
| a peer connects to it, a `fs.readStream` emits an event when the file is | ||
| Many objects in Node.js emit events: a [`net.Server`](net.html#net_class_net_server) emits an event each time | ||
| a peer connects to it, a [`fs.readStream`](fs.html#net_class_net_server) emits an event when the file is |
|
ping @a0viedo |
|
@a0viedo ... is this still a change you'd like to see made? |
|
Sorry for leaving this stranded. Updated the reference that @silverwind pointed out. Also, would love your feedback of future doc changes @jasnell: would be best to group future changes (in different modules) in a single PR? |
|
LGTM |
|
LGTM. @a0viedo ... I'm happy with it either way, really. I know some prefer to see a fewer number of PRs with more changes, others prefer PRs to be more focused. |
| Many objects in Node.js emit events: a `net.Server` emits an event each time | ||
| a peer connects to it, a `fs.readStream` emits an event when the file is | ||
| Many objects in Node.js emit events: a [`net.Server`](net.html#net_class_net_server) emits an event each time | ||
| a peer connects to it, a [`fs.readStream`](fs.html#fs_class_fs_readstream) emits an event when the file is |
There was a problem hiding this comment.
while you are editing this line, could you please fix fs.ReadStream (capital R) ?
|
LGTM with one comment, but that can be taken care of while landing. |
Added referenced method links.
targos
pushed a commit
that referenced
this pull request
Nov 6, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Thanks. Landed in d26927c with an edit to fit 80 characters/line. |
rvagg
pushed a commit
that referenced
this pull request
Nov 7, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
landed in lts-v4.x-staging as 22bfe22 |
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
Added referenced method links. PR-URL: #3187 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added referenced method links.