-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
repl: attach location info to syntax errors
Currently, when a file with a syntax error is imported in the REPL, no information is provided on the error's location. This commit adds the error's location to the stack trace. Refs: #2762 Refs: #3411 Refs: #3784 PR-URL: #4013 Reviewed-By: Ben Noordhuis <[email protected]>
- Loading branch information
Showing
2 changed files
with
40 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const path = require('path'); | ||
const repl = require('repl'); | ||
const util = require('util'); | ||
let found = false; | ||
|
||
process.on('exit', () => { | ||
assert.strictEqual(found, true); | ||
}); | ||
|
||
// A stream to push an array into a REPL | ||
function ArrayStream() { | ||
this.run = function(data) { | ||
data.forEach(line => { | ||
this.emit('data', line + '\n'); | ||
}); | ||
}; | ||
} | ||
util.inherits(ArrayStream, require('stream').Stream); | ||
ArrayStream.prototype.readable = true; | ||
ArrayStream.prototype.writable = true; | ||
ArrayStream.prototype.resume = function() {}; | ||
ArrayStream.prototype.write = function(output) { | ||
if (/var foo bar;/.test(output)) | ||
found = true; | ||
}; | ||
|
||
const putIn = new ArrayStream(); | ||
const testMe = repl.start('', putIn); | ||
let file = path.resolve(__dirname, '../fixtures/syntax/bad_syntax'); | ||
|
||
if (common.isWindows) | ||
file = file.replace(/\\/g, '\\\\'); | ||
|
||
putIn.run(['.clear']); | ||
putIn.run([`require('${file}');`]); |