doc: add backlog for more server.listen variants #4025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
doc
| @@ -102,6 +103,10 @@ This function is asynchronous. When the server has been bound, | |||
| The last parameter `callback` will be added as a listener for the | |||
| ['listening'][] event. | |||
|
|
|||
| The parameter `backlog` behaves the same as in | |||
There was a problem hiding this comment.
Any reason you added this explanation here, but not for the other variation?
|
LGTM with a question. Glad to get this documented. |
|
Does this work on windows, though? |
|
It does! LGTM |
Actually, `backlog` is even supported for the `options` variant; but I think this would be too confusing if documented, as the `options.backlog` property takes precedence.
|
I now added the note for the second variant. I also moved the link into the link definitions. |
cjihrig
pushed a commit
that referenced
this pull request
Dec 16, 2015
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: #4056 PR-URL: #4025 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
Thanks! Landed in 9e1b7aa. |
cjihrig
pushed a commit
that referenced
this pull request
Dec 16, 2015
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: #4056 PR-URL: #4025 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 29, 2015
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: #4056 PR-URL: #4025 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: #4056 PR-URL: #4025 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
The backlog parameter is supported by all variations of net.Server.listen(), but wasn't consistently documented. This commit brings the documentation into a more consistent state. Refs: nodejs#4056 PR-URL: nodejs#4025 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
This was referenced Aug 11, 2020
This was referenced Mar 22, 2022
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually,
backlogis even supported for theoptionsvariant; but I think this would be too confusing if documented, as theoptions.backlogproperty takes precedence.