Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use really invalid hostname #3711

Conversation

thefourtheye
Copy link
Contributor

On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (no.way.you.will.resolve.this) and it times out in local testing.
This patch uses an invalid name (...) and does stricter validation of
the error returned.

On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.
@thefourtheye thefourtheye added the test Issues and PRs related to the tests. label Nov 8, 2015
@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@JungMinu
Copy link
Member

JungMinu commented Nov 8, 2015

LGTM

@evanlucas
Copy link
Contributor

LGTM

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 8, 2015
thefourtheye added a commit that referenced this pull request Nov 9, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 9, 2015

Landed in 5707258

@jasnell jasnell closed this Nov 9, 2015
@Trott
Copy link
Member

Trott commented Nov 9, 2015

Did this get a CI run?

thefourtheye added a commit that referenced this pull request Nov 10, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 10, 2015
thefourtheye added a commit that referenced this pull request Nov 17, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging in 07b5791

thefourtheye added a commit that referenced this pull request Dec 4, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
thefourtheye added a commit that referenced this pull request Dec 17, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
thefourtheye added a commit that referenced this pull request Dec 23, 2015
On my slow Ubuntu 14.04 machine, this fails to resolve the host name
used (`no.way.you.will.resolve.this`) and it times out in local testing.
This patch uses an invalid name (`...`) and does stricter validation of
the error returned.

PR-URL: #3711
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@thefourtheye thefourtheye deleted the improve-test-net-connect-test-case branch March 12, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants