doc: Add explanatory text. #4174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -3,6 +3,8 @@ Node.js | |||
|
|
|||
| [](https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | |||
|
|
|||
| Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js uses an event-driven, non-blocking I/O model that makes it lightweight and efficient. Node.js' package ecosystem, npm, is the largest ecosystem of open source libraries in the world. | |||
There was a problem hiding this comment.
nit: Node.js' package ecosystem -> The Node.js package ecosystem
|
Commit message should be prefixed with |
ghost
changed the title
| @@ -3,6 +3,8 @@ Node.js | |||
|
|
|||
| [](https://gitter.im/nodejs/node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | |||
|
|
|||
| Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js uses an event-driven, non-blocking I/O model that makes it lightweight and efficient. The Node.js' package ecosystem, npm, is the largest ecosystem of open source libraries in the world. | |||
There was a problem hiding this comment.
Can you drop the apostrophe from The Node.js'.
There was a problem hiding this comment.
Please wrap lines at 80 characters.
|
LGTM with comments. |
|
👍 |
|
would you please squash the commits? :) |
|
Thank you. |
|
With corrections made can we pull this in? |
|
LGTM |
|
I don't have merge privileges, so that may be the confusion. |
Trott
pushed a commit
that referenced
this pull request
Dec 8, 2015
Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #4174
|
Landed in a1388bb. Thanks. (There were some trailing spaces I trimmed, no big deal, but if you plan on doing more contributions in the future, FYI.) |
ghost
deleted the
|
Excellent. I'll watch for trailing spaces next time. |
rvagg
pushed a commit
that referenced
this pull request
Dec 9, 2015
Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #4174
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 29, 2015
Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #4174
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: #4174
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> PR-URL: nodejs#4174
This was referenced Mar 18, 2020
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.