Do not unref debug handle to avoid debug process stuck #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
c++
|
Before we go into details, have you checked that it passes |
|
Thanks. I've noticed this patch would cause some tests failed. I will try to fix that. |
|
Change itself LGTM but the commit log needs to confirm to the guidelines from CONTRIBUTING.md. |
The debug process running "node debug a.js" will be stuck when the script ends. This is because the debug handler has been unrefed. We shouldn't unref the debug handler to avoid this problem.
viirya
force-pushed
the
no-unref-debug
branch
from
21af0a4
to
66029bf
Compare
|
@bnoordhuis Thanks for reminding the commit log format. |
|
ping @bnoordhuis I've updated the commit log. Any other comments? |
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 13, 2015
The debug process running "node debug a.js" will be stuck when the script ends. This is because the debug handler has been unrefed. We shouldn't unref the debug handler to avoid this problem. PR-URL: #2778 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in ff877e9, thanks. |
This was referenced Oct 27, 2015
jasnell
pushed a commit
that referenced
this pull request
Oct 28, 2015
The debug process running "node debug a.js" will be stuck when the script ends. This is because the debug handler has been unrefed. We shouldn't unref the debug handler to avoid this problem. PR-URL: #2778 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed in v4.x-staging in dee9c74 |
This was referenced Oct 29, 2015
|
Just a heads up but this PR introduced a regression and I'm moving to revert it, please see #3585. |
|
@bnoordhuis ... ugh... ok |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a simple javascript file:
Run
node debug a.jsto launch debug process. Press firstcand the program outputs> debug. After that, presscagain the process just gets stuck and has no response so we have to kill it.This is because debug handle has been unrefed. Once the program is finished, the event loop will be exited and the debug process will be stuck when debug sends commend again. We shouldn't unref the debug handle because even the script is finished, we can still send more debug command such as
restart.Fixes #1788.