test: don't assume openssl s_client supports -ssl3 #4204
Merged
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if CI and @kapouer are happy with it |
Scan the child process's stderr for an 'unknown flag' error message and mark the test as skipped if found. Fixes: nodejs#3927 PR-URL: nodejs#4204 Reviewed-By: Rich Trott <[email protected]>
bnoordhuis
added a commit
that referenced
this pull request
Dec 15, 2015
Scan the child process's stderr for an 'unknown flag' error message and mark the test as skipped if found. Fixes: #3927 PR-URL: #4204 Reviewed-By: Rich Trott <[email protected]>
Closed
bnoordhuis
added a commit
that referenced
this pull request
Dec 30, 2015
Scan the child process's stderr for an 'unknown flag' error message and mark the test as skipped if found. Fixes: #3927 PR-URL: #4204 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Scan the child process's stderr for an 'unknown flag' error message and mark the test as skipped if found. Fixes: #3927 PR-URL: #4204 Reviewed-By: Rich Trott <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Scan the child process's stderr for an 'unknown flag' error message and mark the test as skipped if found. Fixes: nodejs#3927 PR-URL: nodejs#4204 Reviewed-By: Rich Trott <[email protected]>
This was referenced Mar 18, 2020
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.
Fixes: #3927
R=@Trott? /cc @kapouer
CI: https://ci.nodejs.org/job/node-test-pull-request/963/