-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix debug-port-cluster flakiness #4310
Conversation
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: nodejs#4310 Reviewed-By: Colin Ihrig <[email protected]>
I'm going to close #4258 in favor of this one. This approach seems less prone to flakiness. |
LGTM |
6757182
to
2859f9e
Compare
|
||
var args = [ | ||
'--debug=' + port, | ||
'--debug=' + PORT_MIN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nit... since we're starting to use template strings more frequently... perhaps:
`--debug=${PORT_MIN}`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that in my first (unpushed) revision but then I thought "meh, change for the sake of it and incongruous with the line below" so I left it out.
LGTM |
ha! ok, nevermind, just noticed that it landed lol |
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <[email protected]>
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <[email protected]>
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <[email protected]>
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: nodejs#4310 Reviewed-By: Colin Ihrig <[email protected]>
Rewrite the test so that stderr reordering of the child processes won't
confuse the test's expectations.
CI: https://ci.nodejs.org/job/node-test-pull-request/1013/