Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: optimize callback call with arguments: bind -> arrow #4038

Closed
wants to merge 1 commit into from

Conversation

bsnote
Copy link
Contributor

@bsnote bsnote commented Nov 26, 2015

ES6 arrow functions are much more efficient than .bind() functions.

http://jsperf.com/bind-vs-arrow-function-call

ES6 arrow functions are much more efficient than `.bind()` functions.
@Fishrock123 Fishrock123 added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 26, 2015
@Trott
Copy link
Member

Trott commented Nov 26, 2015

@Fishrock123
Copy link
Contributor

LGTM

Fishrock123 pushed a commit that referenced this pull request Dec 2, 2015
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@Fishrock123
Copy link
Contributor

Thanks, landed in fbcd687

@Fishrock123 Fishrock123 closed this Dec 2, 2015
rvagg pushed a commit that referenced this pull request Dec 5, 2015
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: #4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
ES6 arrow functions are much more efficient than `.bind()` functions.

PR-URL: nodejs#4038
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants