-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark http-pipeline-flood flaky #3616
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-http-pipeline-flood has been flaky on Windows for some time. Hopefully, nodejs#2862 fixes it and lands soon, but until then, let's mark it as flaky.
LGTM |
Landed in 6d6bc5d |
Trott
added a commit
that referenced
this pull request
Nov 2, 2015
test-http-pipeline-flood has been flaky on Windows for some time. Hopefully, #2862 fixes it and lands soon, but until then, let's mark it as flaky. PR-URL: #3616 Reviewed-By: Johan Bergström <[email protected]>
Trott
added a commit
that referenced
this pull request
Nov 7, 2015
test-http-pipeline-flood has been flaky on Windows for some time. Hopefully, #2862 fixes it and lands soon, but until then, let's mark it as flaky. PR-URL: #3616 Reviewed-By: Johan Bergström <[email protected]>
Merged
Holding off on landing this until deciding if #3636 is going to lts |
unmarking this from lts-watch as #3636 has landed in lts |
Closed
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 17, 2016
test-http-pipeline-flood has been flaky on Windows for some time. Hopefully, nodejs#2862 fixes it and lands soon, but until then, let's mark it as flaky. PR-URL: nodejs#3616 Reviewed-By: Johan Bergström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, #2862 fixes it and
lands soon, but until then, let's mark it as flaky.
Recent examples of the test failing on Windows in CI: