deps: backport 8d6a228 from the v8's upstream #4259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indutny
referenced
this pull request
Dec 12, 2015
Original commit message:
[heap] fix crash during the scavenge of ArrayBuffer
Scavenger should not attempt to visit ArrayBuffer's storage, it is a
user-supplied pointer that may have any alignment. Visiting it, may
result in a crash.
BUG=
R=jochen
Review URL: https://codereview.chromium.org/1406133003
Cr-Commit-Position: refs/heads/master@{#31611}
PR-URL: #3549
Reviewed-By: Trevor Norris <[email protected]>
|
The upstream patch included a condition for + } else if (target->IsBytecodeArray()) {
+ IterateAndMarkPointersToFromSpace(
+ target, obj_address + BytecodeArray::kConstantPoolOffset,
+ obj_address + BytecodeArray::kHeaderSize, record_slots, callback); |
|
@zcbenz you are absolutely right. Thanks for catching this! |
Original commit message:
[heap] fix crash during the scavenge of ArrayBuffer
Scavenger should not attempt to visit ArrayBuffer's storage, it is a
user-supplied pointer that may have any alignment. Visiting it, may
result in a crash.
BUG=
R=jochen
Review URL: https://codereview.chromium.org/1406133003
Cr-Commit-Position: refs/heads/master@{nodejs#31611}
PR-URL: nodejs#3549
Reviewed-By: Trevor Norris <[email protected]>
indutny
force-pushed
the
feature/rebackport-32237041b84faa1ddd2caa43c47b8f75135a37f7
branch
from
f64194b
to
65c6208
Compare
|
Force pushed, PTAL |
|
Seems to be just one unrelated failure on fedora, otherwise CI is green. @ofrobots does this PR still look good to you? |
|
I get gateway timeouts on the tap results page for the CI so I cannot verify that the failure is unrelated . LGTM, otherwise. |
|
Rubber stamp LGTM. @indutny ... should this go into LTS? |
|
@jasnell I don't think so, we just forgot to cherry-pick it when upgrading V8 somewhere after LTS (AFAIK) |
|
Landed in 36ac3d6, thank you! |
indutny
deleted the
feature/rebackport-32237041b84faa1ddd2caa43c47b8f75135a37f7
branch
indutny
added a commit
that referenced
this pull request
Dec 14, 2015
Original commit message:
[heap] fix crash during the scavenge of ArrayBuffer
Scavenger should not attempt to visit ArrayBuffer's storage, it is a
user-supplied pointer that may have any alignment. Visiting it, may
result in a crash.
BUG=
R=jochen
Review URL: https://codereview.chromium.org/1406133003
Cr-Commit-Position: refs/heads/master@{#31611}
PR-URL: #4259
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
|
@jasnell: I missed this commit when upgrading from V8 4.6 to V8 4.7 😰. This is not needed in stable or LTS. |
Closed
|
@ofrobots I've added dont-land-on-v4.x please let me know if this should be changed |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Original commit message:
[heap] fix crash during the scavenge of ArrayBuffer
Scavenger should not attempt to visit ArrayBuffer's storage, it is a
user-supplied pointer that may have any alignment. Visiting it, may
result in a crash.
BUG=
R=jochen
Review URL: https://codereview.chromium.org/1406133003
Cr-Commit-Position: refs/heads/master@{nodejs#31611}
PR-URL: nodejs#4259
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
PR-URL: #3549
Reviewed-By: Trevor Norris [email protected]
cc @nodejs/v8