Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add thealphanerd to collaborators #3723

Closed
wants to merge 1 commit into from
Closed

doc: add thealphanerd to collaborators #3723

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

No description provided.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 9, 2015

LGTM

@evanlucas
Copy link
Contributor

LGTM. yay

@Trott
Copy link
Member

Trott commented Nov 9, 2015

:shipit:

@Trott
Copy link
Member

Trott commented Nov 9, 2015

Er, uh, actually, aren't the collaborators listed in alphabetical order by GitHub username?

@evanlucas
Copy link
Contributor

good point

@MylesBorins
Copy link
Contributor Author

fixed

@MylesBorins
Copy link
Contributor Author

Can I get another round of LGTM 😄

@evanlucas
Copy link
Contributor

LGTM

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015
@Trott
Copy link
Member

Trott commented Nov 9, 2015

LGTM

1 similar comment
@saghul
Copy link
Member

saghul commented Nov 9, 2015

LGTM

@MylesBorins
Copy link
Contributor Author

Landed in 7b89a3d

MylesBorins pushed a commit that referenced this pull request Nov 9, 2015
doc: add thealphanerd to collaborators
7b89a3d 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@MylesBorins MylesBorins closed this Nov 9, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 9, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Nov 10, 2015
@Fishrock123
doc: add thealphanerd to collaborators
e5b9109 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Nov 10, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2015
doc: add thealphanerd to collaborators
64e6d06 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@MylesBorins
Copy link
Contributor Author

landed in v4.x-staging in 64e6d06

@rvagg rvagg mentioned this pull request Nov 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 4, 2015
@rvagg
doc: add thealphanerd to collaborators
d27f440 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2015
@jasnell
doc: add thealphanerd to collaborators
5232512 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 23, 2015
@jasnell
doc: add thealphanerd to collaborators
7e98c9c 
PR-URL: #3723
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MylesBorins @cjihrig @evanlucas @Trott @saghul @jasnell @Fishrock123