doc: harmonize description of ca argument
#4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
tls
| @@ -164,8 +164,9 @@ The following options from [`tls.connect()`][] can also be specified. However, a | |||
| - `key`: Private key to use for SSL. Default `null`. | |||
| - `passphrase`: A string of passphrase for the private key or pfx. Default `null`. | |||
| - `cert`: Public x509 certificate to use. Default `null`. | |||
| - `ca`: An authority certificate or array of authority certificates to check | |||
| the remote host against. | |||
| - `ca`: A string, a `Buffer` or an array of strings or `Buffer`s of trusted | |||
There was a problem hiding this comment.
I think the second a should be ommitted.
|
LGTM with the grammatical nit above. |
Different sections said different things about what the `ca` argument should look like. This commit harmonizes them. Ref: nodejs#4099 PR-URL: nodejs#4213 Reviewed-By: Roman Reiss <[email protected]>
bnoordhuis
force-pushed
the
update-ca-doc
branch
from
bd093d9
to
73a9a6f
Compare
|
Landed with nit fixed in 73a9a6f. |
bnoordhuis
added a commit
that referenced
this pull request
Dec 15, 2015
Different sections said different things about what the `ca` argument should look like. This commit harmonizes them. Ref: #4099 PR-URL: #4213 Reviewed-By: Roman Reiss <[email protected]>
Closed
bnoordhuis
added a commit
that referenced
this pull request
Dec 30, 2015
Different sections said different things about what the `ca` argument should look like. This commit harmonizes them. Ref: #4099 PR-URL: #4213 Reviewed-By: Roman Reiss <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Different sections said different things about what the `ca` argument should look like. This commit harmonizes them. Ref: #4099 PR-URL: #4213 Reviewed-By: Roman Reiss <[email protected]>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Different sections said different things about what the `ca` argument should look like. This commit harmonizes them. Ref: nodejs#4099 PR-URL: nodejs#4213 Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different sections said different things about what the
caargumentshould look like. This commit harmonizes them.
Ref: #4099
R=@rvagg