Add caveats section in the doc of crypto #3479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described.
|
|
||
| The crypto module still supports some algorithms which are already | ||
| compromised. And the API also allows to use ciphers and hashes with a | ||
| small key size that are consider to be weak for a safe use. |
There was a problem hiding this comment.
"... that are considered to be too weak for safe use."
|
Looks good in general but a few nits. |
|
@jasnell Thanks. I revised the doc and add a commit. |
brendanashworth
added
crypto
| ## Caveats | ||
|
|
||
| The crypto module still supports some algorithms which are already | ||
| compromised. And the API also allows to use ciphers and hashes with a |
There was a problem hiding this comment.
"And the API also allows the use of ciphers and hashes with a" (replace to with the)
|
Thank you @shigeki ... just a few more I promise ;-). It's great that these recommendations are being updated! |
|
LGTM! Thanks @shigeki ! |
|
@indutny ... any feedback before I land? |
|
@indutny ... ping? |
shigeki
pushed a commit
that referenced
this pull request
Nov 5, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
|
Landed in 017fc5b |
shigeki
pushed a commit
that referenced
this pull request
Nov 7, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Merged
shigeki
pushed a commit
that referenced
this pull request
Nov 16, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
|
landed in lts-v4.x-staging as 4a94c0a |
shigeki
pushed a commit
that referenced
this pull request
Dec 4, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Closed
shigeki
pushed a commit
that referenced
this pull request
Dec 17, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
shigeki
pushed a commit
that referenced
this pull request
Dec 23, 2015
Add description of user responsibility in the choice of cypto algorithms and its key length. Some of recommendations for the safer use are also described. PR-URL: #3479 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is originally from nodejs/node-v0.x-archive#25564.
This adds caveats section in the crypto api documentation to notify users of the risks of weak algorithms and small keys and revises examples to use safe ones.
Fix: #3406