-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: url.format - true slash postfix behaviour #4119
doc: url.format - true slash postfix behaviour #4119
Conversation
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: nodejs#3361
I don't think we should document broken behaviour, see #3361 (comment). |
Well... the current behavior ought to be documented and if it's broken, it ought be fixed ;-) Until it's fixed, it definitely should be documented tho |
Right, you have a point. We can land this and then possible follow up with a breaking change that removes it again. LGTM |
LGTM |
@silverwind once this lands I'll probably submit another PR doing that, will have to add a few tests to test-url (which has gotten quite large, probably a refactor into separate files might be warranted too) |
LGTM |
May I land this? :) |
@JungMinu go ahead. |
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Thanks, landed in 2a29b70 |
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: #3361 PR-URL: #4119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Change url.format's references to slash postfixing to reflect true behaviour (it only automatically postfixes slashes to the slashedProtocols when host is present). Fixes: nodejs#3361 PR-URL: nodejs#4119 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Change url.format's references to slash postfixing to reflect
true behaviour (it only automatically postfixes slashes to the
slashedProtocols when host is present).
Fixes: #3361
Also ccing to #4101