-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to npm 2.14.12 #4110
Conversation
I was unable to apply the patch with |
1st as expected:
2nd also happens with v3.5.0 (I think?), not sure what's up here:
|
I was seeing both of those myself fwiw |
@thealphanerd @Fishrock123 This is the thing where you have to set node to be a release, not a prerelease. See #4003 (comment) |
@zkat ah ok I didn't realize both were from that. :) LGTM @thealphanerd Would you prefer to land it? |
@Fishrock123 sec. After #3959 (comment), I have updated the LICENSE file for node accordingly, so please re-review. @jasnell See new commit! Is this alright now? |
@zkat ... I haven't had a chance to review the entire PR so I can't give an LGTM but the new commit is exactly what I needed! Thanks! |
I have confirmed using diff that the resulting LICENSE is identical to that found on https://github.com/npm/npm/blob/master/LICENSE LGTM |
LGTM. This shouldn't land until the corresponding PR for master also lands tho. |
derp.. nevermind.. sigh. I keep forgetting that master and v5.x are on npm3. sigh. |
Tests passed, for the record. cc @jasnell Edit: with |
@zkat, this PR is not landing cleanly on v4.x-staging for me for some reason. Can you take a moment to do a quick rebase and update then I'll get it landed. |
@jasnell |
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
@zkat nevermind :-) @Fishrock123 .. thanks :-) Landed in fff8132 and 4f8d557 |
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4110 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](#4110)
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [nodejs#3884](nodejs#3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [nodejs#4110](nodejs#4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [nodejs#3938](nodejs#3938) - Updated node LICENSE file with new npm license (Kat Marchán) [nodejs#4110](nodejs#4110)
Hiii!
This PR includes two releases:
The main thing to note is a hopefully welcome update to our licensing to clarify scope of both the open source side and the registry TOS. There's a further clarification coming later this week, so we're not done with that bit yet -- so keep an eye out for v2.14.13.
This PR supersedes #4003, but have a look-see over there for some discussion. That PR should be closeable, though. #4033 was closed because I made it against the wrong branch. Sorry about that. :)
r: @jasnell
r: @Fishrock123
r: @chrisdickinson
r: @thealphanerd