-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: refactor configure args to config_flags #3399
Conversation
17934a8
to
fed29b2
Compare
Perhaps append all old variables to |
those variables are all initialized (emptied if they are already set) at the top of the script, not intended to be used from the outside |
I can confirm that |
LGTM |
1 similar comment
LGTM |
@jasnell LTS? |
@thealphanerd yes, this will have to be in LTS, if it works. Warning @nodejs/platform-windows, imma merge this and if I messed something up because you didn't review then imma blame y'all. |
if "%i18n_arg%"=="small-icu" set config_flags=%config_flags% --with-intl=small-icu | ||
if "%i18n_arg%"=="intl-none" set config_flags=%config_flags% --with-intl=none | ||
|
||
if defined CONFIG_FLAGS set config_flags=%config_flags% %CONFIG_FLAGS% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment variables are case insensitive on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..so if you want to achieve passing additional config flags through an environment var, you would have to name it something different. E.g.: additional_config_flags, or name the other one differently e.g. configure_flags, or _configure_flags
fed29b2
to
7a5ce6a
Compare
LGTM |
Me too. LGTM. |
7a5ce6a
to
2b16824
Compare
will land after 5.1.0 cause there's parts of this that can't be tested by CI but could break releases and I don't want to cause yet another release delay |
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: nodejs#3399 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
2b16824
to
b47d823
Compare
I forgot about this, it was landed on 0.12 and 0.10 already. Landed just now on master @ b47d823 |
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: #3399 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
@rvagg this is not patching cleanly on v4.x-staging Would you be able to make a PR with a working patch |
hey @rvagg another ping regarding this not merging cleanly in 4.x-staging |
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: #3399 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
thanks @thealphanerd, merged @ 093bdcb, running a CI for v4.x-staging just to be sure @ https://ci.nodejs.org/job/node-test-commit/1577/, vcbuild.bat seems to have worked just fine on those. The discrepancy was the addition of the vtune stuff which was noise in the patch and I assume we're not backporting to v4.x. |
thanks @rvagg |
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: #3399 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
remove a bunch of variables and rely on %configure_flags% where possible, also allow for an external %config_flags% variable to supply additional arguments to configure to match the behaviour of the Makefile PR-URL: nodejs#3399 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: João Reis <[email protected]>
Main goal here is to get
--download-path
toconfigure
so we can solve the ICU problems, but while in there I decided that I was sick of the compounding variables we're using to set up the full string so I refactored.Removed a bunch of variables and rely on %config_flags% alone where possible, also allow for an external %CONFIG_FLAGS% variable to supply additional arguments to configure to match the behaviour of the Makefile. That way we can
CONFIG_FLAGS="--download-path=c:\node-icu"
.PTAL @nodejs/platform-windows @nodejs/build