deps: fix upgrade to npm 3.3.6 #3494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI: https://ci.nodejs.org/job/node-test-commit/924/ Edit: fix CI link. |
jbergstroem
added
the
npm
|
CI looks good (minus the tests that have been failing pretty consistently lately) LGTM |
|
LGTM. Will get this landed now so CI can get back on track |
jasnell
pushed a commit
that referenced
this pull request
Oct 23, 2015
41923c0 broke things. This fixes them. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> PR-URL: #3494
|
Landed in 68471dd |
rvagg
pushed a commit
that referenced
this pull request
Oct 26, 2015
41923c0 broke things. This fixes them. Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> PR-URL: #3494
This was referenced Oct 27, 2015
Closed
This was referenced Apr 29, 2023
This was referenced Jun 22, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the debug dep back in for [email protected]. I'll PR separately for fixing the .gitigore to not cause this problem again. This will resolve the problem in #3493