Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify assert.fail doc #4186

Closed
wants to merge 1 commit into from
Closed

doc: clarify assert.fail doc #4186

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 8, 2015

No description provided.

@Trott Trott added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Dec 8, 2015
@targos
Copy link
Member

targos commented Dec 8, 2015

LGTM

2 similar comments
@r-52
Copy link
Contributor

r-52 commented Dec 8, 2015

LGTM

@JungMinu
Copy link
Member

JungMinu commented Dec 9, 2015

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 10, 2015
PR-URL: nodejs#4186
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 10, 2015

Landed in 70fb06a

@Trott Trott closed this Dec 10, 2015
Trott added a commit that referenced this pull request Dec 15, 2015
PR-URL: #4186
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
PR-URL: #4186
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
PR-URL: #4186
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4186
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Trott Trott deleted the assert branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants