Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-cluster-shared-leak flaky #4162

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 5, 2015

test-cluster-shared-leak is flaky on Windows.

Ref: #3956

test-cluster-shared-leak is flaky on Windows.

Ref: nodejs#3956
@Trott Trott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Dec 5, 2015
@Trott
Copy link
Member Author

Trott commented Dec 5, 2015

Also took the opportunity to alphabetize the list of flaky tests on Windows.

@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@r-52
Copy link
Contributor

r-52 commented Dec 5, 2015

LGTM

@JungMinu
Copy link
Member

JungMinu commented Dec 5, 2015

LGTM

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Dec 5, 2015
Trott added a commit that referenced this pull request Dec 6, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@r-52
Copy link
Contributor

r-52 commented Dec 6, 2015

Thanks @Trott - Landed in afd5122

@r-52 r-52 closed this Dec 6, 2015
Trott added a commit that referenced this pull request Dec 8, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: #3956

PR-URL: #4162
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test-cluster-shared-leak is flaky on Windows.

Refs: nodejs#3956

PR-URL: nodejs#4162
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Roman Klauke <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@Trott Trott deleted the double-secret-probation branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants