-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix misaligned columns on Firefox/Linux #3948
Conversation
+1 |
For what it's worth, as I commented on the nodejs/help#32 thread, if I change the body font size style from 62.5% to 100% it looks fine. To be explicit, I changed:
to
then 13em looks fine: |
Still pretty sure we're dealing with a browser bug here. We arrive at body { font-size: 62.5% } /* 10px */
#content { font-size: 1.8em } /* 18px */ Setting body to |
Okay, you are right, not a bug! I restarted firefox with a new profile and the page renders fine. Must be some sort of cruft crept in over the years. Sorry for the noise, thanks for helping me fix my firefox setup, I guess... |
@jmarca thanks for confirming. I still think this patch is good to have either way. |
Anyone able to rubberstamp a LGTM here? It's a bit unfortunate that this CSS isn't on the website repo. |
Rubber-stamp LGTM if it works. It'd be good to test the built docs on a bunch of browsers though since we only update the docs site with releases. |
Yeah, it was confirmed working by the user, I think it's good to use the same unit for the same distance to avoid weird browser bugs like this. Will land shortly. |
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Landed in 8b75030. I'll remember to test the docs in more browsers, thanks. |
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: #3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: nodejs/help#32 PR-URL: nodejs#3948 Reviewed-By: Jeremiah Senkpiel <[email protected]>
13em
and234px
are equivalent here. By using the same unit as is used to specify the width of the TOC, we can work around a presumed Firefox layout bug, see nodejs/help#32.