Add hive boost to climate and water_heater

[KJonline]

Description:

Add the ability to call the boost function for the hive hot water. it will also allow a time period to be set for the climate boost by implementing a hive boost service.

Related issue (if applicable): fixes #25536

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10407

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

[KJonline]

Hi @MartinHjelmare i have updated and moved the service registration and the service handler to the component level now. i have also updated the component to pass through a list for each HA type and in turn within the platform setup iterating through that list adding the entity.

I am struggling with the dispatch_connect and the handle callback. I have tried implementing it as a base class and passing it through, i have even tried implementing it directly into the platform. For some reason which ever way i try and achieve it, the platform i add it to will freeze during setup and HA will stay frozen and not report any errors. Any ideas?

[KJonline]

Hi @MartinHjelmare, I have amended post your recent comments and updated the files passing a list through to Add Entities and introducing a base class for the callback, along with the other changes.

[MartinHjelmare]

This looks like it has been outdented too far.

[KJonline]

Hi @MartinHjelmare, i have committed the latest changes following your last review.

[KJonline]

Hi @MartinHjelmare, i have updated moving the variables to the parent class. i have had to leave one variable in the light child class as it has an extra piece of data which is only available if the device is light.

[KJonline]

Hi @MartinHjelmare, it looks like the pylint check is failing on the platform classes that call the parent class but don’t do anything else within the initialisation process e.g binary_sensor. Where as the climate and light platform which calls the parent and assigns a variable in the child class aren’t being flagged by pylint. Any ideas?

[MartinHjelmare]

In the child classes that doesn't do anything but call the parent class init, we can remove the init method in the child class.

[MartinHjelmare]

Remove this.

[MartinHjelmare]

Remove this.

[MartinHjelmare]

Remove this.

[MartinHjelmare]

Remove this.

[KJonline]

Hi @MartinHjelmare, apoligies i am not familiar with using super(). but when i remove the init method from the child classes i get an error advising

  File "/Users/kholejones/Git/home-assistant/homeassistant/components/hive/sensor.py", line 31, in <module>
    class HiveSensorEntity(HiveEntity, Entity):
  File "/Users/kholejones/Git/home-assistant/homeassistant/components/hive/sensor.py", line 34, in HiveSensorEntity
    super().__init__(hive_session, hive_device)
RuntimeError: super(): no arguments`

I have updated the classes to be the below but keep getting the above error.

class HiveSensorEntity(HiveEntity, Entity):

    super().__init__(hive_session, hive_device)

    @property
    def unique_id(self):
        """Return unique ID of entity."""
        return self._unique_id`

[MartinHjelmare]

Remove the whole init method including the call to super().

[KJonline]

Hi @MartinHjelmare, that’s seems to have passed all the checks now. I just wanted to say thanks for all your help with this. I started learning python with this component and this had been a massive learning curve. Thanks for your patience with me/this and there is still a lot for me to learn but I am looking forward to it.

[MartinHjelmare]

Great!

[frenck]

Noticed during the review of the documentation: hotwater is not one word. So I expected it to be hot_water ?