Add transport data from maps.yandex.ru api by rishatik92 · Pull Request #26252 · home-assistant/core

rishatik92 · 2019-08-28T18:49:15Z

Breaking Change:

Description:

This feature allow to obtain bus departure time at transport stops in many russian cities

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#10375

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: yandex_transport
    stop_id: 9639579

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

homeassistant · 2019-08-28T18:49:17Z

Hi @rishatik92,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

rishatik92 · 2019-08-28T18:58:54Z

Hi all.
Feature was developed in the image dublin_bus_transport (https://www.home-assistant.io/components/dublin_bus_transport/)

MartinHjelmare

Please add a simple docstring to the package __init__.py module too.

MartinHjelmare

Please add the device_class property to the entity and return "timestamp".

https://developers.home-assistant.io/docs/en/entity_sensor.html#available-device-classes

MartinHjelmare · 2019-09-02T05:51:21Z

File CODEOWNERS is not up to date. Please run python3 -m script.hassfest and commit the changes.

MartinHjelmare · 2019-09-02T05:52:21Z

Also run script/gen_requirements_all.py and commit the changes.

MartinHjelmare · 2019-09-02T05:53:35Z

Please also update .coveragerc to exclude this integration.

MartinHjelmare · 2019-09-02T05:55:07Z

These instructions were in the PR template before you removed them.

https://github.com/home-assistant/home-assistant/blob/dev/.github/PULL_REQUEST_TEMPLATE.md

frenck · 2019-09-03T09:02:16Z

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

… in Russia

MartinHjelmare · 2019-09-16T17:21:59Z

Please solve the lint issues and run black to format the code.

rishatik92 · 2019-09-18T20:23:42Z

Please solve the lint issues and run black to format the code.

Done 😊

MartinHjelmare

Great!

rishatik92 · 2019-09-19T20:50:14Z

Great!

Great thanks to you for the instructions! 😊

MartinHjelmare · 2019-09-19T20:50:38Z

Can be merged when build passes.

rishatik92 · 2019-09-19T21:27:46Z

Can be merged when build passes.

lets do it!)

This reverts commit 9e2cd51.

adding feature obtaining Moscow transport data from maps.yandex.ru api

9c681d4

homeassistant added the cla-needed label Aug 28, 2019

probot-home-assistant Bot added new-integration integration: yandex_transport labels Aug 28, 2019

homeassistant added cla-signed and removed cla-needed labels Aug 28, 2019

MartinHjelmare requested changes Aug 31, 2019

View reviewed changes

Comment thread homeassistant/components/moscow_yandex_transport/sensor.py Outdated

MartinHjelmare changed the title ~~adding feature obtaining Moscow transport data from maps.yandex.ru api~~ Add Moscow transport data from maps.yandex.ru api Aug 31, 2019

extracting the YandexMapsRequester to pypi

e1e7d46

MartinHjelmare requested changes Aug 31, 2019

View reviewed changes

fix code review comments

36ced04

MartinHjelmare reviewed Sep 1, 2019

View reviewed changes

fix stop_name, state in datetime, logger formating

ccc8ce1

MartinHjelmare reviewed Sep 1, 2019

View reviewed changes

Comment thread homeassistant/components/moscow_yandex_transport/sensor.py Outdated

Comment thread homeassistant/components/moscow_yandex_transport/sensor.py Outdated

rishatik92 added 2 commits September 1, 2019 23:03

fix comments

5cc230e

add docstring to init

612d619

rishatik92 commented Sep 1, 2019

View reviewed changes

Comment thread homeassistant/components/moscow_yandex_transport/sensor.py Outdated

frenck added the docs-missing label Sep 3, 2019

rename, because it works not only Moscow, but many another big cities…

e409f98

… in Russia

rishatik92 changed the title ~~Add Moscow transport data from maps.yandex.ru api~~ Add transport data from maps.yandex.ru api Sep 4, 2019

rishatik92 added 3 commits September 4, 2019 23:36

fix comments

f36bc3c

Try to solve relative view in sensor timestamp

bf62be3

back to isoformat

65d12e4

add tests, update external library version

e3b5894

rishatik92 requested a review from MartinHjelmare September 18, 2019 20:22

rishatik92 added 2 commits September 18, 2019 23:34

flake8 and black tests for sensor.py

18dd4ed

fix manifest.json

98fc10b

MartinHjelmare reviewed Sep 18, 2019

View reviewed changes

Comment thread tests/components/yandex_transport/mock_import.py Outdated

rishatik92 added 3 commits September 19, 2019 01:22

update tests, migrate to pytest, async, Using MockDependency

8e2a0e0

move json to tests/fixtures

986dabb

script/lint fixes

2609797

MartinHjelmare reviewed Sep 18, 2019

View reviewed changes

fix comments

0d110ea

rishatik92 requested a review from MartinHjelmare September 19, 2019 17:35

MartinHjelmare reviewed Sep 19, 2019

View reviewed changes

Comment thread tests/components/yandex_transport/test_yandex_transport_sensor.py Outdated

removing check_filter function

9e135f7

rishatik92 requested a review from MartinHjelmare September 19, 2019 20:28

MartinHjelmare reviewed Sep 19, 2019

View reviewed changes

Comment thread tests/components/yandex_transport/test_yandex_transport_sensor.py Outdated

fix typo

1c98ff1

rishatik92 requested a review from MartinHjelmare September 19, 2019 20:36

MartinHjelmare approved these changes Sep 19, 2019

View reviewed changes

MartinHjelmare removed the docs-missing label Sep 19, 2019

MartinHjelmare merged commit 9e2cd51 into home-assistant:dev Sep 19, 2019

pvizeli added a commit that referenced this pull request Sep 20, 2019

Revert "Add transport data from maps.yandex.ru api (#26252)"

85e1921

This reverts commit 9e2cd51.

pvizeli mentioned this pull request Sep 20, 2019

Revert "Add transport data from maps.yandex.ru api" #26762

Merged

pvizeli added a commit that referenced this pull request Sep 20, 2019

Revert "Add transport data from maps.yandex.ru api (#26252)" (#26762)

9e44d1a

This reverts commit 9e2cd51.

lock Bot locked and limited conversation to collaborators Sep 20, 2019

Uh oh!

Conversation

rishatik92 commented Aug 28, 2019 • edited by MartinHjelmare Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

homeassistant commented Aug 28, 2019

Uh oh!

rishatik92 commented Aug 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare commented Sep 2, 2019

Uh oh!

MartinHjelmare commented Sep 2, 2019

Uh oh!

MartinHjelmare commented Sep 2, 2019

Uh oh!

MartinHjelmare commented Sep 2, 2019

Uh oh!

frenck commented Sep 3, 2019

Uh oh!

MartinHjelmare commented Sep 16, 2019

Uh oh!

rishatik92 commented Sep 18, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

rishatik92 commented Sep 19, 2019

Uh oh!

MartinHjelmare commented Sep 19, 2019

Uh oh!

rishatik92 commented Sep 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

rishatik92 commented Aug 28, 2019 •

edited by MartinHjelmare

Loading

Example entry for `configuration.yaml` (if applicable):