Fix bed_activity history chart of the Xiaomi Aqara vibration sensor#26875
Merged
syssi merged 2 commits intoSep 25, 2019
Conversation
probot-home-assistant
Bot
added
integration: xiaomi_aqara
small-pr
syssi
approved these changes
Sep 24, 2019
MartinHjelmare
changed the title
| "illumination": ["lm", None, DEVICE_CLASS_ILLUMINANCE], | ||
| "lux": ["lx", None, DEVICE_CLASS_ILLUMINANCE], | ||
| "pressure": ["hPa", None, DEVICE_CLASS_PRESSURE], | ||
| "bed_activity": ["μm", None, DEVICE_CLASS_PRESSURE], |
Member
There was a problem hiding this comment.
Is this sensor really measuring pressure?
Contributor
Author
There was a problem hiding this comment.
Is this sensor really measuring pressure?
this is vibration sensor.
https://www.aqara.com/en/vibration_sensor.html
Member
There was a problem hiding this comment.
Then we should not use DEVICE_CLASS_PRESSURE. We can replace that with None.
Contributor
Author
There was a problem hiding this comment.
Then we should not use
DEVICE_CLASS_PRESSURE. We can replace that withNone.
done.
syssi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
fix xiaom activity sensor show in history chart.
changed before like this, not show x-y chart:
changed after:
Checklist:
tox. Your PR cannot be merged unless tests pass