Centralize rainbird config and add binary sensor platform

[konikvranik]

Breaking Change:

The configuration has been changed and all configuration is now done under the rainbird: key in configuration.yaml. Configuration of rainbird switches is moved from platform config section to main rainbird: config under zones: key. Please read the updated documentation.

Description:

• Bump pyrainbird to 0.4.1
• Cache states of sprinklers for efficient communication to controller
• fixed rainsensor state
• added rainsensor binary sensor

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10326

Example entry for configuration.yaml:

rainbird:
  host: IP_ADDRESS_OF_MODULE
  password: YOUR_PASSWORD
  trigger_time: 6
  zones:
    1:
      trigger_time: 6

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

[MartinHjelmare]

Since this PR already is a breaking change, I suggest we also change to use discovery.load_platform to load the platforms from the component, instead of using platform config sections. This is our new standard to collect all config under the integration key in the config.

This will make it easier to continue expanding this integration.

[MartinHjelmare]

Please revert unrelated changes.

[konikvranik]

Since this PR already is a breaking change, I suggest we also change to use discovery.load_platform to load the platforms from the component, instead of using platform config sections. This is our new standard to collect all config under the integration key in the config.

This will make it easier to continue expanding this integration.

Please look at d6dd916 if that's the way you intended

[MartinHjelmare]

Please don't add more features to this PR after this.

[konikvranik]

There has to be upgrade to pyrainbird 0.4.1. Testing with HA I found bug there

[MartinHjelmare]

Make sure to bump the library versions here too. They are still at 0.4.0.

[konikvranik]

I'm not owner of pyraindbird library so I have to wait until @jbarrancos publishes it to pypi.
Then I will update it here.

[konikvranik]

Upgraded to pyrainbird 0.4.1, tested on local instance and all seems to work flawlessly

[konikvranik]

@jbarrancos May I ask you how does scan_interval works?
Home assistant core finds out if component has this flag in config and in that case it sets proper update interval?
Or how is update scheduled? I can not find docs which explain it.

[MartinHjelmare]

Good! Can be merged when final comment is addressed and build passes.

[MartinHjelmare]

Please also set the defaults as before.

[MartinHjelmare]

Please set the defaults as before too.

[konikvranik]

I'm sorry, which defaults do you mean?

[MartinHjelmare]

The defaults we removed here:
60ae83a#diff-d575fd59bad63f44b30cd5e8ef6286baL39-L44

[konikvranik]

If you mean _set_defaults to set irrigation times for zones in configuration time, it does not make sense. Zones are not known in configuration time, so could not be set. They are discovered from controller in time of platform setup.

[MartinHjelmare]

We have a zone config schema. We should set the default trigger time in the zone schema.

[konikvranik]

We can set values only for zones we want to overwrite some config. We can not overwrite irrigation time for zones that we don't have in configuration. So it is nonsense to substitute default twice. In config and then in runtime. That will be code duplication. What will be that for?

[MartinHjelmare]

Ok. Address the last comment and we're ready.

[MartinHjelmare]

Good!

[MartinHjelmare]

Can be merged when build passes.