Skip to content

Add sensor platform to iaqualink component#26544

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
flz:iaqualink-sensor
Sep 10, 2019
Merged

Add sensor platform to iaqualink component#26544
MartinHjelmare merged 2 commits into
home-assistant:devfrom
flz:iaqualink-sensor

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented Sep 9, 2019

Description:

Add sensor platform support to iaqualink integration.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10334

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 9, 2019

Documentation to follow.

Comment thread homeassistant/components/iaqualink/sensor.py Outdated
Comment thread homeassistant/components/iaqualink/sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes and a docs PR is linked in the PR description.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 9, 2019

Thanks! Waiting for home-assistant/home-assistant.io#10165 to land so I can submit the doc PR for this platform.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 10, 2019

Documentation PR at home-assistant/home-assistant.io#10334.

@MartinHjelmare MartinHjelmare merged commit a7830bc into home-assistant:dev Sep 10, 2019
@flz flz deleted the iaqualink-sensor branch September 10, 2019 20:19
@lock lock Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants