Skip to content

Add built in weather to Homematic IP Cloud#26642

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
SukramJ:HmIP-simpleWeather
Sep 14, 2019
Merged

Add built in weather to Homematic IP Cloud#26642
MartinHjelmare merged 1 commit into
home-assistant:devfrom
SukramJ:HmIP-simpleWeather

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Sep 14, 2019

Description:

This PR adds the built in weather functionality.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@SukramJ SukramJ changed the title Add build in weather to Homematic IP Cloud Add buildin weather to Homematic IP Cloud Sep 14, 2019
@MartinHjelmare MartinHjelmare changed the title Add buildin weather to Homematic IP Cloud Add builtin weather to Homematic IP Cloud Sep 14, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Add builtin weather to Homematic IP Cloud Add built in weather to Homematic IP Cloud Sep 14, 2019
@MartinHjelmare MartinHjelmare merged commit 24f1ff0 into home-assistant:dev Sep 14, 2019
@SukramJ SukramJ deleted the HmIP-simpleWeather branch September 14, 2019 15:44
@lock lock Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants