deCONZ - battery sensor instead of battery attribute#26591
Merged
Conversation
Kane610
force-pushed
the
deconz-battery-sensor
branch
2 times, most recently
from
7493dc6 to
f8a69ac
Compare
Kane610
force-pushed
the
deconz-battery-sensor
branch
from
f8a69ac to
005a665
Compare
Member
Author
|
@MartinHjelmare any additional comments? |
Member
Author
|
Awesome, thanks @MartinHjelmare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Standardizes battery sensor unique id to the serial number of device + battery.
Entity attribute battery level will no longer be available, this will instead be exposed as a separate entity just as with remotes previously.
Description:
Move battery attribute to a standalone sensor per physical device
Related issue (if applicable): fixes Kane610/deconz#42
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: