Skip to content

Bump geniushub-client to 0.6.13#26554

Merged
zxdavb merged 5 commits into
home-assistant:devfrom
zxdavb:bugfix_geniushub
Sep 10, 2019
Merged

Bump geniushub-client to 0.6.13#26554
zxdavb merged 5 commits into
home-assistant:devfrom
zxdavb:bugfix_geniushub

Conversation

@zxdavb
Copy link
Copy Markdown
Member

@zxdavb zxdavb commented Sep 10, 2019

Breaking Change:

None known.

Description:

There was a bug introduced to the geniushubclient during one of its recent refactors where it no longer refreshed entities' data attribute. Since initial values were correct, the library passed it's QC/CI tests, despite subsequent values remaining static.

This PR addresses that issue: manzanotti/geniushub-client@v0.6.11...v0.6.13

Related issue (if applicable): fixes #26539

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zxdavb zxdavb changed the title bump geniushub client bugfix geniushub Sep 10, 2019
@zxdavb zxdavb changed the title bugfix geniushub bugfix geniushub (bumps client) Sep 10, 2019
@zxdavb zxdavb marked this pull request as ready for review September 10, 2019 11:50
@MartinHjelmare MartinHjelmare changed the title bugfix geniushub (bumps client) Bump geniushubclient to 0.6.13 Sep 10, 2019
@MartinHjelmare MartinHjelmare changed the title Bump geniushubclient to 0.6.13 Bump geniushub-client to 0.6.13 Sep 10, 2019
@zxdavb zxdavb merged commit fbc3376 into home-assistant:dev Sep 10, 2019
@zxdavb
Copy link
Copy Markdown
Member Author

zxdavb commented Sep 10, 2019

Thanks @MartinHjelmare

@zxdavb zxdavb deleted the bugfix_geniushub branch September 10, 2019 15:20
@lock lock Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geniushub climate entities do not update

3 participants