Skip to content

Bump pyobihai, add unique ID and availability#26922

Merged
pvizeli merged 3 commits into
home-assistant:devfrom
dshokouhi:bump_pyobibihai
Sep 26, 2019
Merged

Bump pyobihai, add unique ID and availability#26922
pvizeli merged 3 commits into
home-assistant:devfrom
dshokouhi:bump_pyobibihai

Conversation

@dshokouhi
Copy link
Copy Markdown
Member

@dshokouhi dshokouhi commented Sep 25, 2019

Breaking Change:

Description:

Bump pyobihai so credentials are stored and not used in each method per recommendation #26867 (comment). Add unique ID as device serial for entity registry. Add availability if there is a state.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#N/A

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: obihai
    host: 192.168.1.x

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

Comment thread homeassistant/components/obihai/sensor.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pvizeli pvizeli merged commit 62cea2b into home-assistant:dev Sep 26, 2019
@dshokouhi dshokouhi deleted the bump_pyobibihai branch September 26, 2019 13:01
@lock lock Bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants